New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691715 link

Starred by 1 user
Status: Duplicate
Owner:
█ zijiehe@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome crashes when right-clicking on Incognito titlebar

Project Member Reported by elawrence@chromium.org, Feb 13 2017 
Chrome Version: 58.0.3011.0
OS: Windows 10

What steps will reproduce the problem?
(1) Start an Incognito instance
(2) Right-click the title bar

Crashes.

Example server ID: cb63bc3580000000

Comment 1 by elawrence@chromium.org, Feb 13 2017

Owner: zijiehe@chromium.org
You are probably looking for a change made after 449895 (known good), but no later than 449896 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1a8d5f3805dbae5242cf7dce14df3807344dae37..3c7af99a93f4b4837b2fbee5cb66697f66ccf241

Which seems to contain only:
https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66697f66ccf241

Comment 2 by elawrence@chromium.org, Feb 13 2017 

The CL in question looks pretty harmless, but it looks like the crash is here:

bool SystemMenuModelDelegate::IsCommandIdEnabled(int command_id) const

... Because handling of the IDC_RESTORE_TAB command IDs changed, we hit code that we didn't before:

sessions::TabRestoreService* trs =
     TabRestoreServiceFactory::GetForProfile(browser_->profile());
	  if (!trs->IsLoaded()) {
	    trs->LoadTabsFromLastSession();
	    return false;
	  }

Comment 3 by elawrence@chromium.org, Feb 13 2017 

This seems to fix it:

  - if (!trs->IsLoaded()) {
  + if (trs && !trs->IsLoaded()) {

Existing callers elsewhere appear to have the same null-checking.

Comment 4 by elawrence@chromium.org, Feb 13 2017

Mergedinto: 691677
Status: Duplicate (was: Untriaged)

Comment 5 by zijiehe@chromium.org, Feb 13 2017 

Thank you Eric. Feel free to reach me again if anything else I can help.
►

Sign in to add a comment