MD Settings: Add MIDI devices to content settings |
|||||||||
Issue descriptionIn MD Settings > Privacy and Security > Content settings, there is no MIDI section. In the old Settings this section is labeled as "MIDI devices full control" (labeled "MIDI system exclusive messages filter", contentType "midi-sysex" in content_settings.html).
,
Feb 13 2017
+bettes: Do you have a preferred location in the site settings list and icon? This doesn't appear on Android. Tommy
,
Feb 13 2017
Thanks! BTW, This (I think) is the web API affected: https://developer.mozilla.org/en-US/docs/Web/API/MIDIAccess I do not think that it even applies to Chrome OS (but do not know for sure). It is probably most similar to 'USB devices' and is grouped just above 'USB devices' in old Settings.
,
Feb 15 2017
Hello bettes: I'm working on this and I have a few questions: 1. Does the pictured location of MIDI devices make sense to you? 2. What's the icon you prefer for MIDI devices? 3. What's the title? The Old Options has "MIDI devices full control". 4. Do the strings in the screenshots (copied from Options) look okay?
,
Feb 16 2017
My take: 1. Location seems reasonable 2. How about https://icons.googleplex.com/#icon=ic_music_note&search=music ? 3. Not sure why the "full control" is there, "MIDI devices" seems fine to me 4. Re-using options strings seems fine
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d718c1107d57b641ae0a77e6c491c76c3c05fb3 commit 3d718c1107d57b641ae0a77e6c491c76c3c05fb3 Author: tommycli <tommycli@chromium.org> Date: Thu Feb 16 22:18:26 2017 MD Settings: Add MIDI devices to Content Settings BUG= 691711 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2699793003 Cr-Commit-Position: refs/heads/master@{#451114} [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/app/settings_strings.grdp [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/route.js [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/site_settings/category_default_setting.js [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/site_settings/constants.js [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/3d718c1107d57b641ae0a77e6c491c76c3c05fb3/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
,
Feb 16 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tommycli@chromium.org
, Feb 13 2017Status: Assigned (was: Available)