New issue
Advanced search Search tips

Issue 691696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Mock out retry waits in Autotest unittests

Project Member Reported by ayatane@chromium.org, Feb 13 2017

Issue description

dev_server_unittest.py contains multiple retry waits in the unittests.  This alone adds about 20 seconds of wasted time to running unittests.  I suspect that there are other tests as well that include waits.
 

Comment 1 by aut...@google.com, Feb 15 2017

Labels: Hotlist-Fixit
Adding to Fixit list (unless ayatane@ is working on this now?)
Owner: ayatane@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed3f149995d231fa2e7e26b039ea701447341757

commit ed3f149995d231fa2e7e26b039ea701447341757
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jun 30 03:01:02 2017

[autotest] Mock out retry waiting in tests

This is an example of how to save 20 seconds in unit tests with
minimal effort.

BUG= chromium:691696 
TEST=None

Change-Id: I281f2fc06de2e393639ff8afe545ea2553321fcc
Reviewed-on: https://chromium-review.googlesource.com/545113
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/ed3f149995d231fa2e7e26b039ea701447341757/client/common_lib/cros/retry_unittest.py
[modify] https://crrev.com/ed3f149995d231fa2e7e26b039ea701447341757/client/common_lib/cros/dev_server_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment