New issue
Advanced search Search tips

Issue 691655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Do not upload thread load to UMA when throttling is disabled by command-line flag.

Project Member Reported by altimin@chromium.org, Feb 13 2017

Issue description

Throttling can be disabled by a command line flag for testing, which can skew results for testing. We should disable reporting when we see this flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/815ec31ab7487998e1bc713a1fc7124041405dca

commit 815ec31ab7487998e1bc713a1fc7124041405dca
Author: altimin <altimin@chromium.org>
Date: Mon Feb 13 20:50:34 2017

[scheduler] Don't report thread load to UMA when throttling is disabled.

BUG= 691655 

Review-Url: https://codereview.chromium.org/2697643002
Cr-Commit-Position: refs/heads/master@{#450076}

[modify] https://crrev.com/815ec31ab7487998e1bc713a1fc7124041405dca/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Labels: -Pri-3 Merge-Request-57 OS-All Pri-1

Comment 3 Deleted

Project Member

Comment 4 by sheriffbot@chromium.org, Feb 14 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 Deleted

Could you please merge your CL into M57 branch 2987 before 4 PM PT today, Tuesday (02/14/17). Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfac077f46cae7ed8ec36fbf143d22fcecebf9a

commit 2dfac077f46cae7ed8ec36fbf143d22fcecebf9a
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Feb 16 12:41:39 2017

[scheduler] Don't report thread load to UMA when throttling is disabled.

BUG= 691655 

Review-Url: https://codereview.chromium.org/2697643002
Cr-Commit-Position: refs/heads/master@{#450076}
(cherry picked from commit 815ec31ab7487998e1bc713a1fc7124041405dca)

Review-Url: https://codereview.chromium.org/2700773002 .
Cr-Commit-Position: refs/branch-heads/2987@{#545}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2dfac077f46cae7ed8ec36fbf143d22fcecebf9a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Sign in to add a comment