New issue
Advanced search Search tips

Issue 691643 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

In payment request form, for the admin area field show admin areas' names rather than keys.

Project Member Reported by parastoog@chromium.org, Feb 13 2017

Issue description

Chrome Version       : 55.0.2883.87
OS Version: 
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Open payment request form.
2. Try to add an address.
3. The admin area list shows admin area keys (abbreviations).

What is the expected result?

The form should show admin area names (such as California), and save the key (such as CA)

What happens instead of that?

The form shows admin area keys.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36



 
Owner: parastoog@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
Cc: parastoog@chromium.org rouslan@chromium.org se...@chromium.org
 Issue 740258  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51456a9609172d3f8a803c056c1789a55b52fd60

commit 51456a9609172d3f8a803c056c1789a55b52fd60
Author: parastoog <parastoog@google.com>
Date: Mon Jul 10 19:12:08 2017

- In payment request form,
for the admin area drop-down field,
show admin areas' complete names rather than codes.

- If available, show the names in the device's language,
otherwise, show in the default language for that country.

Exp: Show Quebec and not QC, and show Québec
if the device's language is set to French.

- If the name of the admin area for a country
is not available, show the admin area code.

- Change the unit-tests accordingly.

BUG= 691643 

Review-Url: https://codereview.chromium.org/2966103002
Cr-Commit-Position: refs/heads/master@{#485338}

[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/components/payments/core/subkey_requester.cc
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/components/payments/core/subkey_requester.h
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/components/payments/core/subkey_requester_unittest.cc
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/third_party/libaddressinput/chromium/chrome_address_validator.h
[modify] https://crrev.com/51456a9609172d3f8a803c056c1789a55b52fd60/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment