Data reduction proxy should not fetch preconnect/warmpup URL on offline connections |
|||||
Issue descriptionData reduction proxy should not fetch preconnect/warmpup URL on offline connections. Fetching it on offline connections is a waste of resources, and can also lead to alternative proxy getting marked as bad. See https://crbug.com/684761 for context.
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73319e0970ff6421af9ebd06e6cef8de27a8d42b commit 73319e0970ff6421af9ebd06e6cef8de27a8d42b Author: tbansal <tbansal@chromium.org> Date: Wed Feb 15 06:21:41 2017 DRP: Do not fetch warm up URL on offline connections This CL makes a change to not fetch preconnect / warmup URL for data reduction proxy (DRP) if the connectivity is unavailable. BUG= 691620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2687193006 Cr-Commit-Position: refs/heads/master@{#450589} [modify] https://crrev.com/73319e0970ff6421af9ebd06e6cef8de27a8d42b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/73319e0970ff6421af9ebd06e6cef8de27a8d42b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h [modify] https://crrev.com/73319e0970ff6421af9ebd06e6cef8de27a8d42b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
,
Feb 15 2017
,
Feb 16 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT Friday (02/17), so we can pick it up for next week Beta release. Thank you.
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab7e6d815208554d8f61e4b2623e4f4697c731fb commit ab7e6d815208554d8f61e4b2623e4f4697c731fb Author: Tarun Bansal <tbansal@google.com> Date: Fri Feb 17 20:19:23 2017 DRP: Do not fetch warm up URL on offline connections This CL makes a change to not fetch preconnect / warmup URL for data reduction proxy (DRP) if the connectivity is unavailable. BUG= 691620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2687193006 Cr-Commit-Position: refs/heads/master@{#450589} (cherry picked from commit 73319e0970ff6421af9ebd06e6cef8de27a8d42b) Review-Url: https://codereview.chromium.org/2700203002 . Cr-Commit-Position: refs/branch-heads/2987@{#578} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/ab7e6d815208554d8f61e4b2623e4f4697c731fb/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/ab7e6d815208554d8f61e4b2623e4f4697c731fb/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h [modify] https://crrev.com/ab7e6d815208554d8f61e4b2623e4f4697c731fb/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
,
Feb 17 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbansal@chromium.org
, Feb 13 2017