New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691596 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Extension icons overlap the settings bar after resize

Reported by ash.sc...@elev8.digital, Feb 13 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.37 Safari/537.36

Steps to reproduce the problem:
1. Launch chrome with extensions
2. Resize the browser to say, mobile
3. Go back to full screen, icons overlap

What is the expected behavior?
Shouldn't overlap

What went wrong?
As a web developer I occasionally resize the window to check media queries. When I do this, once I scale back to full screen, the icons are overlapping the settings button, and go off screen so I can't get to some.

It only does it when you resize it. A lot of times it's easier to just shrink the window than it is to use dev tools to do the same thing.

Did this work before? N/A 

Chrome version: 57.0.2987.37  Channel: beta
OS Version: OS X 10.11.6
Flash Version:

 
Screen Shot 2017-02-13 at 16.06.20.png
14.8 KB View Download
I've created a gif to show what I mean, as it's hard to explain. https://gyazo.com/4b9c08f1f760b0dc889fc475a1bfb501
Labels: -Pri-2 Hotlist-CocoaBrowser Pri-3
I bet this problem is related to incorrect usage of autoresizing mask on the omnibox. Unfortunately, we're just not going to be able to get to this before switching to MacViews browser, which is a while off.
Status: Available (was: Unconfirmed)

Comment 4 by meh...@chromium.org, Feb 15 2017

Cc: sdy@chromium.org
We had a similar bug which was tracked and fixed in  issue 681004 . Can you reproduce it with latest Canary from https://www.google.de/chrome/browser/canary.html ?

Thanks for your feedback in advance.


Comment 5 by sdy@chromium.org, Feb 15 2017

Cc: -sdy@chromium.org
Labels: -Pri-3 Needs-Bisect Pri-1
Owner: sdy@chromium.org
Status: Assigned (was: Available)
I can reproduce this, need a bisect to confirm when it started.

Comment 6 by sdy@chromium.org, Feb 15 2017

As a workaround, you can rearrange the icons so that the most important extensions are at the left, then drag the divider to hide some of them.

(I bumped the priority because I suspect this was triggered by the RTL work lgrey@ has been doing. If so, it's a recent regression.)
I've confirmed it still happens in Canary (58.0.3013.0 (Official Build) canary (64-bit)).

@sdy Good shout, I've moved everything up in order of most used. Thanks for the suggestion!

Comment 8 by ajha@chromium.org, Feb 23 2017

Labels: Needs-Triage-M57
Cc: lgrey@chromium.org brajkumar@chromium.org
Labels: -Type-Bug -Needs-Bisect -Needs-Triage-M57 hasbisect-per-revision ReleaseBlock-Stable M-57 Type-Bug-Regression
Bisect Information:
---------------------

Good build: 57.0.2972.0
Bad build:  57.0.2974.0

Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 441924 (known good), but no later than 441925 (first known bad).

CHANGE-LOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/5d044bb4fef05b493693b2d548352bc025f08d46..8b0fd02afc2107ba123774e0a464a43407a108cf

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2607533004

Note: Adding RB-Stable since this is a recent regression on M57, please feel free to edit if this is not the case.

Thanks!
URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
lgrey@ - are you able to take a look at this?

Comment 12 by lgrey@chromium.org, Feb 23 2017

Cc: sdy@chromium.org
Owner: lgrey@chromium.org
Will look now
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c2f4bb0e4c021de15a5ae97d86c3cb35f44e50

commit d7c2f4bb0e4c021de15a5ae97d86c3cb35f44e50
Author: lgrey <lgrey@chromium.org>
Date: Thu Feb 23 21:39:37 2017

[Mac] Shrink width of browser action container when location bar is min size

BUG= 691596 

Review-Url: https://codereview.chromium.org/2709083005
Cr-Commit-Position: refs/heads/master@{#452639}

[modify] https://crrev.com/d7c2f4bb0e4c021de15a5ae97d86c3cb35f44e50/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Labels: TE-Verified-58.0.3024.0 TE-Verified-M58
Verified this issue on Mac OS 10.12 using chrome latest canary M58-58.0.3024.0 and observed no overlapping of extensions icons while minimizing the chrome window. Hence adding TE-Verified label for M-58.

Thanks!
Thank you Bibin for verifying bug on Canary.
lgrey@, please request a merge to M57 if you think it will be a safe merge. Thank you.

Comment 16 by lgrey@chromium.org, Feb 27 2017

Labels: Merge-Request-57
Project Member

Comment 17 by sheriffbot@chromium.org, Feb 27 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7fef325ed0a2c4c534e67524873b3cdbae14838

commit b7fef325ed0a2c4c534e67524873b3cdbae14838
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Feb 27 15:44:13 2017

[Mac] Shrink width of browser action container when location bar is min size

BUG= 691596 

Review-Url: https://codereview.chromium.org/2709083005
Cr-Commit-Position: refs/heads/master@{#452639}
(cherry picked from commit d7c2f4bb0e4c021de15a5ae97d86c3cb35f44e50)

Review-Url: https://codereview.chromium.org/2716283003 .
Cr-Commit-Position: refs/branch-heads/2987@{#696}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b7fef325ed0a2c4c534e67524873b3cdbae14838/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Labels: TE-Verified-57.0.2987.88 TE-Verified-M57
Verified this issue on Mac OS 10.12.3 using chrome Beta version# 57.0.2987.88 and no overlapping of extensions icons are observed while minimizing the chrome window. 

Adding TE-Verified label for M-57.

Thanks!
Cc: ranjitkan@chromium.org
Status: Verified (was: Assigned)

Sign in to add a comment