This is a tracking bug for collection work related to the stability file.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4904876279fbe19be093f6a669fd71905a4ac14c commit 4904876279fbe19be093f6a669fd71905a4ac14c Author: manzagop <manzagop@chromium.org> Date: Mon Feb 20 15:02:53 2017 Collect field trial information from the stability file Field trial information is recorded using the global user data mechanism (https://crrev.com/2666653002/). This CL revises global user data collection such that field trial data is processed (from strings to finch identifiers) and collected to a new field trial field in the report. BUG=691595 Review-Url: https://codereview.chromium.org/2691033002 Cr-Commit-Position: refs/heads/master@{#451625} [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/BUILD.gn [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/DEPS [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/postmortem_report_collector.cc [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/postmortem_report_collector.h [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/postmortem_report_collector_unittest.cc [modify] https://crrev.com/4904876279fbe19be093f6a669fd71905a4ac14c/components/browser_watcher/stability_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d348bbd2a92cc6e784868019bc2a1822e2437c59 commit d348bbd2a92cc6e784868019bc2a1822e2437c59 Author: manzagop <manzagop@chromium.org> Date: Wed Mar 01 22:47:40 2017 Get visibility into stability file accumulation While testing the current code, I noticed a stability file that is missing version details nevers gets uploaded or deleted. This CL: - treats writedump failures as non-recoverable and deletes the file - introduces a metric for the number of stability files BUG=691595 Review-Url: https://codereview.chromium.org/2719343002 Cr-Commit-Position: refs/heads/master@{#454078} [modify] https://crrev.com/d348bbd2a92cc6e784868019bc2a1822e2437c59/components/browser_watcher/postmortem_report_collector.cc [modify] https://crrev.com/d348bbd2a92cc6e784868019bc2a1822e2437c59/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d901940e770f2494539d0bf177ae6cd027a8b19 commit 6d901940e770f2494539d0bf177ae6cd027a8b19 Author: manzagop <manzagop@chromium.org> Date: Tue Mar 07 21:53:46 2017 Separate collection logic from the extraction of the report Separate collection logic (identifying files, registering reports with crashpad, calling the minidump writer) from the actual extraction of the report proto from disk. BUG=691595 Review-Url: https://codereview.chromium.org/2722223002 Cr-Commit-Position: refs/heads/master@{#455232} [modify] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/BUILD.gn [modify] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/postmortem_report_collector.cc [modify] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/postmortem_report_collector.h [modify] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/postmortem_report_collector_unittest.cc [add] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/postmortem_report_extractor.cc [add] https://crrev.com/6d901940e770f2494539d0bf177ae6cd027a8b19/components/browser_watcher/postmortem_report_extractor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae commit 4c123ff892dc70fc8b14b15ef01cf3bc14a57dae Author: manzagop <manzagop@chromium.org> Date: Mon Mar 13 21:30:13 2017 Stability file: collect generic activities Also ensure activity time, address and origin address are always collected. BUG=691595 Review-Url: https://codereview.chromium.org/2748823002 Cr-Commit-Position: refs/heads/master@{#456493} [modify] https://crrev.com/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae/components/browser_watcher/dump_postmortem_minidump_main_win.cc [modify] https://crrev.com/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae/components/browser_watcher/postmortem_report_collector_unittest.cc [modify] https://crrev.com/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae/components/browser_watcher/postmortem_report_extractor.cc [modify] https://crrev.com/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae/components/browser_watcher/stability_report.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0793c6c441b24c31bf2c890d243b1875a51abe80 commit 0793c6c441b24c31bf2c890d243b1875a51abe80 Author: manzagop <manzagop@chromium.org> Date: Sun Apr 23 12:10:37 2017 Postmortem report collection: validate internal state This change introduces checking of the underlying allocator's state (initialized, deleted, corrupt, valid). Stability files are no longer deleted on clean exit but instead marked as deleted. BUG=691595 Review-Url: https://codereview.chromium.org/2767193002 Cr-Commit-Position: refs/heads/master@{#466561} [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/base/debug/activity_analyzer.cc [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/base/debug/activity_analyzer.h [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/base/debug/activity_tracker.cc [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/base/debug/activity_tracker.h [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/components/browser_watcher/postmortem_report_collector_unittest.cc [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/components/browser_watcher/postmortem_report_extractor.cc [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/components/browser_watcher/stability_report.proto [modify] https://crrev.com/0793c6c441b24c31bf2c890d243b1875a51abe80/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/194acde6446e88d5ac045e9768ef53aea4319def commit 194acde6446e88d5ac045e9768ef53aea4319def Author: manzagop <manzagop@chromium.org> Date: Mon Jun 05 21:12:24 2017 Decouple stability instrumentation recording and collection Introduces an experiment parameter to control postmortem collection. Depending on the parameter's value, stability files are either collected or simply deleted. Additional details: - UncleanShutdownCount and UncleanSystemCount metrics are deprecated in favor of additional events in ActivityTracker.Collect.Status. This is more memory efficient. BUG=691595 Review-Url: https://codereview.chromium.org/2923523002 Cr-Commit-Position: refs/heads/master@{#477085} [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/BUILD.gn [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/features.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/features.h [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/postmortem_report_collector.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/postmortem_report_collector.h [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/postmortem_report_collector_unittest.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/stability_paths.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/stability_paths.h [add] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/stability_paths_unittest.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/stability_report_extractor.h [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/components/browser_watcher/watcher_metrics_provider_win.cc [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/tools/metrics/histograms/enums.xml [modify] https://crrev.com/194acde6446e88d5ac045e9768ef53aea4319def/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a95d3f14a92b9377d8d94885414a6b1ce2710db commit 1a95d3f14a92b9377d8d94885414a6b1ce2710db Author: manzagop <manzagop@chromium.org> Date: Wed Jun 07 19:29:06 2017 Relocate stability report extraction tests to seperate file BUG=691595 Review-Url: https://codereview.chromium.org/2926113002 Cr-Commit-Position: refs/heads/master@{#477725} [modify] https://crrev.com/1a95d3f14a92b9377d8d94885414a6b1ce2710db/components/browser_watcher/BUILD.gn [modify] https://crrev.com/1a95d3f14a92b9377d8d94885414a6b1ce2710db/components/browser_watcher/postmortem_report_collector_unittest.cc [add] https://crrev.com/1a95d3f14a92b9377d8d94885414a6b1ce2710db/components/browser_watcher/stability_report_extractor_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f commit 27f4805ad79030129eaa9f2e5fa5cf1f8b77393f Author: manzagop <manzagop@chromium.org> Date: Thu Aug 17 20:32:13 2017 StabilityReport multi-process collection support Introduces multi-process collection support. Note that multi-processing recording was introduced in https://codereview.chromium.org/2680123003. Details: - processes now have a process type and key-value data. - modules are now attributed to a process - now collecting all processes, not just the first - some key-value data (version information, timestamp) remains at report scope, to simplify report parsing BUG=691595 Review-Url: https://codereview.chromium.org/2966563004 Cr-Commit-Position: refs/heads/master@{#495306} [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/base/debug/activity_analyzer.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/base/debug/activity_analyzer.h [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/base/debug/activity_analyzer_unittest.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/chrome/browser/chrome_browser_field_trials_desktop.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/dump_stability_report_main_win.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/stability_data_names.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/stability_data_names.h [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/stability_report.proto [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/stability_report_extractor.cc [modify] https://crrev.com/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f/components/browser_watcher/stability_report_extractor_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81b0303149ad9b71df1d7005ce2d8d408df22984 commit 81b0303149ad9b71df1d7005ce2d8d408df22984 Author: Pierre-Antoine Manzagol <manzagop@chromium.org> Date: Tue Aug 22 17:08:57 2017 Decouple stability file processing from crash report generation This CL introduces processing of the stability files even when postmortem crash report collection is disabled, thus enabling collection of user metrics. Bug: 691595 Change-Id: I0c843b61dc1d00a8b072f1f5f41c0237337df0b4 Reviewed-on: https://chromium-review.googlesource.com/619768 Commit-Queue: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#496336} [modify] https://crrev.com/81b0303149ad9b71df1d7005ce2d8d408df22984/components/browser_watcher/postmortem_report_collector.cc [modify] https://crrev.com/81b0303149ad9b71df1d7005ce2d8d408df22984/components/browser_watcher/postmortem_report_collector.h [modify] https://crrev.com/81b0303149ad9b71df1d7005ce2d8d408df22984/components/browser_watcher/postmortem_report_collector_unittest.cc [modify] https://crrev.com/81b0303149ad9b71df1d7005ce2d8d408df22984/components/browser_watcher/watcher_metrics_provider_win.cc
Comment 1 by bugdroid1@chromium.org
, Feb 20 2017