New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691577 link

Starred by 1 user
Status: Fixed
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ zqzh...@chromium.org
mfo...@chromium.org
mlamouri@chromium.org
taku...@chromium.org
powerb@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Remote Playback notifications do not show the origin

Project Member Reported by mlamouri@chromium.org, Feb 13 2017 
STR:
- go to https://avayvod.github.io/remote-playback/test.html
- press play
- press prompt
- pick cast device

Expected result: there is a notification with https://avayvod.github.io as the origin like regular media notifications

Actual result: the origin isn't visibile
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/201ab5f17e23e13c6797cfe3215dca8808bb6313

commit 201ab5f17e23e13c6797cfe3215dca8808bb6313
Author: avayvod <avayvod@chromium.org>
Date: Wed May 03 21:59:18 2017

[Cast,Android] Add origin to the Cast notification

We get the current tab's URL when the notification is shown.

BUG= 691577 
TEST=existing tests+manual

Review-Url: https://codereview.chromium.org/2860633002
Cr-Commit-Position: refs/heads/master@{#469150}

[modify] https://crrev.com/201ab5f17e23e13c6797cfe3215dca8808bb6313/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

Comment 2 by avayvod@chromium.org, May 3 2017

Components: Blink>Media>RemotePlayback Internals>Cast>MediaFling
Labels: -M-59 M-60
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21e42d8f013f59f7764b466f05c7433640eae1b2

commit 21e42d8f013f59f7764b466f05c7433640eae1b2
Author: avayvod <avayvod@chromium.org>
Date: Tue May 09 04:15:53 2017

[Android, Cast] Get the notification origin from the correct tab.

BUG= 691577 
TEST=existing tests

Review-Url: https://codereview.chromium.org/2862153002
Cr-Commit-Position: refs/heads/master@{#470192}

[modify] https://crrev.com/21e42d8f013f59f7764b466f05c7433640eae1b2/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
►

Sign in to add a comment