New issue
Advanced search Search tips

Issue 691566 link

Starred by 1 user
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Mar 2017
Cc:
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 114475



Sign in to add a comment

NetworkStateNotifier should be a platform-layer concept

Project Member Reported by kinuko@chromium.org, Feb 13 2017 
NetworkStateNotifier is currently implemented in Source/core/page/NetworkStateNotifier and is exposed via public/web, but it looks it should basically be a platform-layer concept and should be decoupled from core layer.

Related cleanups:

* Remove ExecutionContext::postTask
* Remove dependency to ExecutionContext
* Make the online/offline state follow observer pattern and remove dependency to Page::networkStateChanged(), which also allows us to have these on Workers and unblocks crbug.com/114475
* Move NetworkStateNotifier to platform/network

Comment 1 by kinuko@chromium.org, Feb 13 2017

Components: Blink>Internals>Modularization
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d

commit fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d
Author: kinuko <kinuko@chromium.org>
Date: Thu Feb 23 16:12:28 2017

Remove Page dependency from NetworkStateNotifier

OnLine event notification should be done via observer model so that we can:
- eliminate Page dependency from NetworkStateNotifier
- make it easy to support online event in Workers

BUG= 691566 

Review-Url: https://codereview.chromium.org/2704083002
Cr-Commit-Position: refs/heads/master@{#452511}

[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/page/NetworkStateNotifier.h
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1

commit fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1
Author: kinuko <kinuko@chromium.org>
Date: Wed Mar 08 04:01:06 2017

Move NetworkStateNotifier from core (and web) into platform/network

BUG= 691566 

Review-Url: https://codereview.chromium.org/2710023006
Cr-Commit-Position: refs/heads/master@{#455376}

[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/android_webview/renderer/aw_render_thread_observer.cc
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/frame/NavigatorOnLine.h
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/platform/exported/WebNetworkStateNotifier.cpp
[rename] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp
[rename] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h
[rename] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/public/BUILD.gn
[rename] https://crrev.com/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1/third_party/WebKit/public/platform/WebNetworkStateNotifier.h

Comment 5 by kinuko@chromium.org, Mar 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment