Issue metadata
Sign in to add a comment
|
Colour in certain animated GIFVs on IMGUR messing up
Reported by
stuart.e...@gmail.com,
Feb 13 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3010.0 Safari/537.36 Example URL: http://i.imgur.com/sGdNbtG.gifv Steps to reproduce the problem: 1. Click animated GIFV link to IMGUR 2. Profit 3. What is the expected behavior? Not to be pink and cyan. What went wrong? When playing back animated GIFV files on Imgur.com the colour in chrome canary is messed up, with a pink and cyan hue. Another example: http://i.imgur.com/sGdNbtG.gifv Did this work before? Yes About Thursday 9th Feb version. Is it a problem with Flash or HTML5? N/A Does this work in other browsers? Yes Chrome version: 58.0.3010.0 Channel: canary OS Version: 10.0 Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Rasterization: Software only, hardware acceleration unavailable Video Decode: Hardware accelerated Video Encode: Hardware accelerated VPx Video Decode: Hardware accelerated WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_discard_framebuffer disable_dxgi_zero_copy_video disable_framebuffer_cmaa exit_on_context_lost force_cube_complete scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected GPU rasterization should only be enabled on NVIDIA Pascal and Maxwell, Intel Broadwell+, and AMD RX-R2 GPUs for now.: 643850 Disabled Features: gpu_rasterization Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa Zero-copy NV12 video displays incorrect colors on NVIDIA drivers.: 635319 Applied Workarounds: disable_dxgi_zero_copy_video Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Version Information Data exported 13/02/2017, 11:34:22 Chrome version Chrome/58.0.3010.0 Operating system Windows NT 10.0.14393 Software rendering list version 12.10 Driver bug list version 9.30 ANGLE commit id 875bbba0eeed 2D graphics backend Skia/58 3c727d2386059c1d7cbdcdc9bef5fa18ed33667e Command Line Args Elliott\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --flag-switches-begin --flag-switches-end Driver Information Initialization time 124 In-process GPU false Passthrough Command Decoder false Sandboxed false GPU0 VENDOR = 0x10de, DEVICE= 0x100c *ACTIVE* GPU1 VENDOR = 0x0000, DEVICE= 0x0000 Optimus false AMD switchable false Desktop compositing Aero Glass Diagonal Monitor Size of \\.\DISPLAY6 26.9" Diagonal Monitor Size of \\.\DISPLAY7 27.0" Driver vendor NVIDIA Driver version 21.21.13.7633 Driver date 12-11-2016 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 8 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (NVIDIA GeForce GTX TITAN Black Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.875bbba0eeed) GL_EXTENSIONS GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Google Inc. (adapter LUID: 00000001070bae02) Window system binding version 1.4 (ANGLE 2.1.0.875bbba0eeed) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXT_pixel_format_float EGL_ANGLE_display_texture_share_group Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 Software only BGRX_8888 Software only BGRA_8888 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1440 dwRefreshRate 59 dwWHQLLevel 0 dwWidth 2560 iAdapter 0 lDriverSize 16875464 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Enabled szChipType GeForce GTX TITAN Black szD3DStatusEnglish Enabled szD3DStatusLocalized Enabled szDACType Integrated RAMDAC szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Enabled szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeVC1_C ModeWMV9_C szDescription NVIDIA GeForce GTX TITAN Black szDeviceId 0x100C szDeviceIdentifier {D7B71E3E-534C-11CF-C76D-6B301BC2D835} szDeviceName \\.\DISPLAY6 szDisplayMemoryEnglish 22455 MB szDisplayMemoryLocalized 22455 MB szDisplayModeEnglish 2560 x 1440 (32 bit) (59Hz) szDisplayModeLocalized 2560 x 1440 (32 bit) (59Hz) szDriverAssemblyVersion 21.21.13.7849 szDriverAttributes Final Retail szDriverDateEnglish 20/01/2017 00:00:00 szDriverDateLocalized 1/20/2017 00:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized English szDriverModelEnglish WDDM 2.1 szDriverModelLocalized WDDM 2.1 szDriverName C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvd3dumx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll szDriverNodeStrongName oem56.inf:0f066de3182d45bb:Section018:21.21.13.7849:pci\ven_10de&dev_100c szDriverSignDate Unknown szDriverVersion 21.21.0013.7849 szKeyDeviceID Enum\PCI\VEN_10DE&DEV_100C&SUBSYS_106610DE&REV_A1 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{B0B1A8A0-46B1-4C92-9085-DB58846F3A8D}\0000 szManufacturer NVIDIA szMiniVdd unknown szMiniVddDateEnglish Unknown szMiniVddDateLocalized unknown szMonitorMaxRes Unknown szMonitorName Dell U2713H(DP) szNotesEnglish No problems found. szNotesLocalized No problems found. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x00A1 szSubSysId 0x106610DE szTestResultD3D7English Not run szTestResultD3D7Localized Not run szTestResultD3D8English Not run szTestResultD3D8Localized Not run szTestResultD3D9English Not run szTestResultD3D9Localized Not run szTestResultDDEnglish Not run szTestResultDDLocalized Not run szVdd unknown szVendorId 0x10DE 1 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1080 dwRefreshRate 60 dwWHQLLevel 0 dwWidth 1920 iAdapter 1 lDriverSize 16875464 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Enabled szChipType GeForce GTX TITAN Black szD3DStatusEnglish Enabled szD3DStatusLocalized Enabled szDACType Integrated RAMDAC szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Enabled szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeVC1_C ModeWMV9_C szDescription NVIDIA GeForce GTX TITAN Black szDeviceId 0x100C szDeviceIdentifier {D7B71E3E-534C-11CF-C76D-6B301BC2D835} szDeviceName \\.\DISPLAY7 szDisplayMemoryEnglish 22455 MB szDisplayMemoryLocalized 22455 MB szDisplayModeEnglish 1920 x 1080 (32 bit) (60Hz) szDisplayModeLocalized 1920 x 1080 (32 bit) (60Hz) szDriverAssemblyVersion 21.21.13.7849 szDriverAttributes Final Retail szDriverDateEnglish 20/01/2017 00:00:00 szDriverDateLocalized 1/20/2017 00:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized English szDriverModelEnglish WDDM 2.1 szDriverModelLocalized WDDM 2.1 szDriverName C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvd3dumx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll,C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_02838dee03d82b94\nvwgf2umx.dll szDriverNodeStrongName oem56.inf:0f066de3182d45bb:Section018:21.21.13.7849:pci\ven_10de&dev_100c szDriverSignDate Unknown szDriverVersion 21.21.0013.7849 szKeyDeviceID Enum\PCI\VEN_10DE&DEV_100C&SUBSYS_106610DE&REV_A1 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{B0B1A8A0-46B1-4C92-9085-DB58846F3A8D}\0001 szManufacturer NVIDIA szMiniVdd unknown szMiniVddDateEnglish Unknown szMiniVddDateLocalized unknown szMonitorMaxRes Unknown szMonitorName Dell S2740L(HDMI) szNotesEnglish No problems found. szNotesLocalized No problems found. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x00A1 szSubSysId 0x106610DE szTestResultD3D7English Not run szTestResultD3D7Localized Not run szTestResultD3D8English Not run szTestResultD3D8Localized Not run szTestResultD3D9English Not run szTestResultD3D9Localized Not run szTestResultDDEnglish Not run szTestResultDDLocalized Not run szVdd unknown szVendorId 0x10DE Log Messages [61548:62976:0213/104950.042:ERROR:angle_platform_impl.cc(33)] : rx::Renderer11::testDeviceLost(2669): The D3D11 device was removed, HRESULT: 0x887A0005 [61548:62976:0213/104950.042:ERROR:gles2_cmd_decoder.cc(4229)] : GLES2DecoderImpl: Context lost during MakeCurrent. [61548:62976:0213/104950.042:ERROR:gpu_channel_manager.cc(228)] : Exiting GPU process because some drivers cannot recover from problems. [61548:62976:0213/104950.042:ERROR:gpu_channel_manager.cc(228)] : Exiting GPU process because some drivers cannot recover from problems. GpuProcessHostUIShim: The GPU process exited normally. Everything is okay. [40896:46108:0213/111659.901:ERROR:mf_helpers.cc(12)] : Error in dxva_video_decode_accelerator_win.cc on line 1500 [40896:46108:0213/111659.901:ERROR:mf_helpers.cc(12)] : Error in dxva_video_decode_accelerator_win.cc on line 610 [40896:46108:0213/111659.901:ERROR:gpu_video_decode_accelerator.cc(375)] : HW video decode not available for profile vp8 [40896:46108:0213/113105.180:ERROR:mf_helpers.cc(12)] : Error in dxva_video_decode_accelerator_win.cc on line 1500 [40896:46108:0213/113105.180:ERROR:mf_helpers.cc(12)] : Error in dxva_video_decode_accelerator_win.cc on line 610 [40896:46108:0213/113105.180:ERROR:gpu_video_decode_accelerator.cc(375)] : HW video decode not available for profile vp8 GpuProcessHostUIShim:
,
Feb 13 2017
,
Feb 13 2017
,
Feb 14 2017
Unable to reproduce this issue on windows 10 with chrome version #58.0.3011.0 After clicking on the animated GIFV link to IMGUR, it has redirected to imgur.com Didn't observe any pink and cyan colors on the screen while playing the videos. Attaching the screen-cast for your reference. stuart.elliott@ could you please retry the same scenario with clean profile with no apps & extensions and let us know your observations.
,
Feb 14 2017
Just in case this wasn't already clear to everybody: The left picture in #1 is YUV, but displayed as RGB. Also, don't let the GIFV confuse you (as they did me), these are videos.
,
Feb 14 2017
Since the reporter has an nvidia card, it seems likely that they are hitting the "copy nv12" path in the HW decoder, but for some reason we are not converting the YUV values to RGB?
,
Feb 14 2017
I think the problem is here: https://cs.chromium.org/chromium/src/cc/output/gl_renderer.cc?=3032 If I'm reading the code right, it skips YUV->RGB color conversion if the output color space is not set and there is no fallback to using linear transformations?
,
Feb 14 2017
If no dst space is set, then we do yuv->rgb conversion using a uniform matrix (the usual way) https://cs.chromium.org/chromium/src/cc/output/gl_renderer.cc?rcl=be40a647b788038f94500f7329fa194ef8519d2d&l=2034 If a dst space is set, then we set the uniform matrix to be the resource mutiplier+offset thing. Adding needs-bisect and seeing if I can reproduce it.
,
Feb 14 2017
Ah, missed that part. That does look correct. We have an experiment that enables color management, maybe there is something broken when color management is on? Also, not sure if we can reproduce this, so bisecting might be difficult.
,
Feb 14 2017
Can we see if this user has video color management enabled? If video color management is enabled, but quad->video_color_space is not set (or is set wrong), then could be interpreting the raw YUV as SRGB. In fact, if I go to gl_renderer.cc and just don't set src_color_space ... // TODO(ccameron): There are currently three sources of the color space: the // resource, quad->color_space, and quad->video_color_space. Remove two of // them. gfx::ColorSpace src_color_space; // = quad->video_color_space; gfx::ColorSpace dst_color_space = current_frame()->device_color_space; ... then I get what the user is seeing (not on this video on Mac, cause I'm on a Mac, but in videos that have YUVDrawQuad). So ... are we not setting quad->video_color_space in this decode path?
,
Feb 14 2017
"Can we see if this user has video color management enabled?" Tell me what I should be looking at?
,
Feb 14 2017
Re #11: That's odd, color space should default to BT709, so not setting it should be the same as setting it to BT709..... Although, in your code, we could end up with no yuv to rgb conversion of output color space is set but not input color space, right? I'm not sure why the input color space wouldn't be set though. Maybe I missed something in VideoLayerImpl...
,
Feb 15 2017
Yes, if output is set but no input is set, then we'll get no YUV to RGB We could CHECK that the source color space isn't RGB for YUV draw quads, and that would quickly tell us if this is true.
,
Feb 15 2017
I think there are two bugs here: 1) if the color space is not set, gl_render.cc needs to behave as if it was BT709 2) the color space should always be set :)
,
Feb 15 2017
2. Definitely. 1. Mostly... - should it be sRGB (PrimaryID::BT709, TransferID::IEC61966_2_1, MatrixID::RGB, RangeID::FULL) - or should it be rec709 YUV (PrimaryID::BT709, TransferID::BT709, MatrixID::BT709, RangeID::LIMITED) rec709 makes sense for YUVVideoDrawQuad, but not so much for the other DrawQuad types (which assume some sort or RGB inputs). I'll make sure we get rec709 as the default for YUVVideoDrawQuad in a patch I'm working on.
,
Feb 15 2017
I think we should make ColorSpace itself agnostic and DCHECK if you try to use the defaults, then add a method that lets you easily specify what you want your defaults to be.
,
Feb 15 2017
Issue 691814 has been merged into this issue.
,
Feb 15 2017
Fix is up at https://codereview.chromium.org/2697863003/. I wonder if we could have started this experiment at 100% for Canary, to flush out huge bugs like this.
,
Feb 15 2017
Knew you'd get there in the end. :)
,
Feb 16 2017
I thought this was a css issue with facebook, but as the screenshot shows, finding the source video itself gives this casted effect. I can confirm that the media player plays this correctly. Not an issue with youtube though. Media Info for demo clip: General Complete name : C:\******\1662956_730948346923483_1372151812_n.mp4 Format : MPEG-4 Format profile : Facebook Codec ID : FACE (isom/avc1/FACE) File size : 1.71 MiB Duration : 15 s 645 ms Overall bit rate mode : Variable Overall bit rate : 918 kb/s Encoded date : UTC 2014-02-13 10:27:25 Tagged date : UTC 2014-02-13 10:27:25 Video ID : 1 Format : AVC Format/Info : Advanced Video Codec Format profile : High@L3.1 Format settings, CABAC : Yes Format settings, ReFrames : 4 frames Codec ID : avc1 Codec ID/Info : Advanced Video Coding Duration : 15 s 645 ms Bit rate : 768 kb/s Maximum bit rate : 1 315 kb/s Width : 1 280 pixels Height : 720 pixels Display aspect ratio : 16:9 Frame rate mode : Constant Frame rate : 15.020 FPS Color space : YUV Chroma subsampling : 4:2:0 Bit depth : 8 bits Scan type : Progressive Bits/(Pixel*Frame) : 0.055 Stream size : 1.43 MiB (84%) Writing library : x264 core 116 Encoding settings : cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=15 / keyint_min=8 / scenecut=40 / intra_refresh=0 / rc_lookahead=15 / rc=2pass / mbtree=1 / bitrate=768 / ratetol=1.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / cplxblur=20.0 / qblur=0.5 / vbv_maxrate=922 / vbv_bufsize=3842 / nal_hrd=none / ip_ratio=1.40 / aq=1:1.00 Encoded date : UTC 2014-02-13 10:27:25 Tagged date : UTC 2014-02-13 10:27:25 Audio ID : 2 Format : AAC Format/Info : Advanced Audio Codec Format profile : LC Codec ID : 40 Duration : 15 s 487 ms Bit rate mode : Variable Bit rate : 150 kb/s Maximum bit rate : 179 kb/s Channel(s) : 2 channels Channel positions : Front: L R Sampling rate : 44.1 kHz Frame rate : 43.066 FPS (1024 spf) Compression mode : Lossy Stream size : 283 KiB (16%) Title : /tmp/730948263590158_audio.aac - Imported with GPAC 0.4.6-DEV-rev3544 Encoded date : UTC 2014-02-13 10:27:25 Tagged date : UTC 2014-02-13 10:27:25 FACE codec ID. Busy boys at facebook. Wonder if they've got any ideas re: the wheel?
,
Feb 16 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/172d451b1f1d429ce496c0bb4c57e8e4874cdc43 commit 172d451b1f1d429ce496c0bb4c57e8e4874cdc43 Author: ccameron <ccameron@chromium.org> Date: Fri Feb 17 00:15:44 2017 color: Clarify default behaviors Change YUVDrawFrame to use REC709 if no valid color space is specified. Make ColorTransform do nothing if the source color space is invalid. Add a method for constructing video color spaces, CreateVideo, which does translation from h264 spec values to gfx::ColorSpace values. For now, leave all values in existence, though they can likely be removed in the future. Change the media/ callers that used to static-cast h264 values to use this constructor. Change the ColorSpace PrimaryID/TransferID/MatrixID to not exactly match the h264 spec (offset by 1000) to discourage doing static casts. Add a method to query the h264 values for casting. Change vp9 to always specify a color space to its frame, even when one is not known. BUG= 691522 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2697863003 Cr-Commit-Position: refs/heads/master@{#451151} [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/cc/ipc/struct_traits_unittest.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/cc/output/gl_renderer.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/chromecast/media/cma/base/decoder_config_adapter.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/ffmpeg/ffmpeg_common.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/ffmpeg_video_decoder.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/h264_parser.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/vpx_video_decoder.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/formats/webm/webm_colour_parser.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space.h [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space_win.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_transform.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_transform_unittest.cc
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/172d451b1f1d429ce496c0bb4c57e8e4874cdc43 commit 172d451b1f1d429ce496c0bb4c57e8e4874cdc43 Author: ccameron <ccameron@chromium.org> Date: Fri Feb 17 00:15:44 2017 color: Clarify default behaviors Change YUVDrawFrame to use REC709 if no valid color space is specified. Make ColorTransform do nothing if the source color space is invalid. Add a method for constructing video color spaces, CreateVideo, which does translation from h264 spec values to gfx::ColorSpace values. For now, leave all values in existence, though they can likely be removed in the future. Change the media/ callers that used to static-cast h264 values to use this constructor. Change the ColorSpace PrimaryID/TransferID/MatrixID to not exactly match the h264 spec (offset by 1000) to discourage doing static casts. Add a method to query the h264 values for casting. Change vp9 to always specify a color space to its frame, even when one is not known. BUG= 691522 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2697863003 Cr-Commit-Position: refs/heads/master@{#451151} [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/cc/ipc/struct_traits_unittest.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/cc/output/gl_renderer.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/chromecast/media/cma/base/decoder_config_adapter.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/ffmpeg/ffmpeg_common.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/ffmpeg_video_decoder.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/h264_parser.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/filters/vpx_video_decoder.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/media/formats/webm/webm_colour_parser.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space.h [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_space_win.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_transform.cc [modify] https://crrev.com/172d451b1f1d429ce496c0bb4c57e8e4874cdc43/ui/gfx/color_transform_unittest.cc
,
Feb 17 2017
Should be fixed now.
,
Feb 17 2017
Thank you, 58.0.3014 still had the issue, but fixed in 58.0.3015.
,
Feb 17 2017
Verified this issue in Windows 10 with chrome canary #58.0.3015.0, observed that issue is got fixed. Attaching the screen-cast for reference. Hence adding TE-verified labels.
,
Feb 17 2017
,
Feb 17 2017
hi thanks for fixing this - see comment on https://bugs.chromium.org/p/chromium/issues/detail?id=692068#c12 I wonder why this was not able to be bisected in Chromium or even Chrome official builds?
,
Feb 18 2017
,
Feb 20 2017
Issue 693940 has been merged into this issue.
,
Feb 21 2017
Issue 694298 has been merged into this issue.
,
Feb 21 2017
Issue 694381 has been merged into this issue.
,
Feb 21 2017
hello I wonder if you could answer question in #30 or https://bugs.chromium.org/p/chromium/issues/detail?id=692068#c12 specifically about why this was bisectable - this might help future regressions of this type.
,
Feb 21 2017
We couldn't bisect it because we couldn't reproduce it. It's likely that this bug was triggered by an experiment, which would explain why some people see the bug and others do not.
,
Feb 21 2017
I tried using the same official release binaries, and forced my field trial configuration to the same configuration as the exact same Chrome Canary that I was experiencing it on, using the same hardware, and was still unable to reproduce. Is there some other configuration that needs to be set to opt into the experiment? What was the experiment?
,
Feb 21 2017
Assuming the experiment is what I think it is, you can enable it with the flag: --enable-features=video-color-management and you can disable it with --disable-features=video-color-management
,
Feb 21 2017
Issue 694427 has been merged into this issue.
,
Feb 21 2017
Issue 694012 has been merged into this issue.
,
Feb 21 2017
re: #38 thanks for the info, I've raised issue 694675 to deal with reproducing/bisecting bugs that are exposed only by enabling certain features.
,
Feb 23 2017
,
Feb 24 2017
,
Mar 7 2017
I wonder if the issue I'm seeing is related: Attached is the image I observe from this URL. https://twitter.com/ABC/status/838909828604964864 I'm using Version 59.0.3032.0 (Official Build) canary (64-bit) on Mac OS X 10.12.3 MacPro. Flags I'm turning on are: - Show Autofill predictions - Developer Tools experiments - Material Design in the rest of the browser's native UI - Google profile name and icon - Enable Material Design settings I don't think these are related to the issue.
,
Mar 7 2017
Re: #45: I'm also still seeing the issue on Canary (Chrome 59.0.3032.0) as well as Dev (Chrome 58.0.3026.3) on OSX 10.12.3, including for auto-playing images on Twitter. I had tagged onto Issue 694614 for this, but it got duped into here.
,
Mar 7 2017
Please open a new bug. It may be issue 698860 -- those pictures don't look like YUV planes (maybe channel flip?).
,
Mar 7 2017
re #47: Done, at Issue 698977 . |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Feb 13 2017