Please report timezone for start/end of the build |
|||
Issue descriptionThere is "(All times local)" in the bottom of the page, but it's not prominent enough making the user wonder what timezone "Mon, 2017-02-13 10:26:37" is in. Can we please add "(local time)" after the time?
,
Feb 13 2017
Since this is an aesthetic change, it's hard to know the impact without screenshots :). So uploading a tainted version and attaching a screenshot would be the right course. I vaguely remember doing this before but scrapped the idea because the timestamps became overtly long. There's nothing special about milo that wouldn't work with gae.py. There's a shortcut in the makefile so that if you run "make up" then it'll call gae.py and pass in the default args for you, but that's optional.
,
Feb 15 2017
lgtm, I was always in favor of doing this for the same reason - glad we're fixing it. :)
,
Feb 15 2017
,
Feb 15 2017
Issue 692309 has been merged into this issue.
,
Feb 15 2017
Please just always put a timezone rather than "local time". "local time" doesn't mean anything, it is never clear who the "local" is? Is it local to the bot, local to the appengine app, the browser, the user's preferences, who!? "US/Pacific", "PDT" or "+10:00" is clearer and exact.
,
Feb 15 2017
Unfortunately we can't derive the exact timezone name from the browser, but +10:00 is doable.
,
Feb 15 2017
I personally prefer +/-<amount> as you then don't have to look up the offset :-)
,
Feb 17 2017
Done. CL and tainted versions are updated.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/b517e730515610038aa8ef9c6d9c4ef2c5d4c05c commit b517e730515610038aa8ef9c6d9c4ef2c5d4c05c Author: sergiyb <sergiyb@chromium.org> Date: Wed Mar 01 08:41:06 2017 Display "(local time)" label after start/end time of the build R=hinoka@chromium.org BUG= 691493 Review-Url: https://codereview.chromium.org/2691003002 [modify] https://crrev.com/b517e730515610038aa8ef9c6d9c4ef2c5d4c05c/milo/appengine/frontend/static/common/js/time.js
,
Mar 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by serg...@chromium.org
, Feb 13 2017