New issue
Advanced search Search tips

Issue 691493 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Please report timezone for start/end of the build

Project Member Reported by serg...@chromium.org, Feb 13 2017

Issue description

There is "(All times local)" in the bottom of the page, but it's not prominent enough making the user wonder what timezone "Mon, 2017-02-13 10:26:37" is in. Can we please add "(local time)" after the time?
 
If we agree this is a reasonable thing to do, then here is CL: http://crrev.com/2691003002. I'd also be interested in re-deploying the app myself to get experience contributing to Milo, but please let me know whether I need do to anything beyond running gae.py and flipping the active version to avoid breaking the world.

Comment 2 by hinoka@chromium.org, Feb 13 2017

Since this is an aesthetic change, it's hard to know the impact without screenshots :).  So uploading a tainted version and attaching a screenshot would be the right course.

I vaguely remember doing this before but scrapped the idea because the timestamps became overtly long.

There's nothing special about milo that wouldn't work with gae.py.  There's a shortcut in the makefile so that if you run "make up" then it'll call gae.py and pass in the default args for you, but that's optional.

Comment 4 by estaab@chromium.org, Feb 15 2017

lgtm, I was always in favor of doing this for the same reason - glad we're fixing it. :)

Comment 5 by estaab@chromium.org, Feb 15 2017

Owner: serg...@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by hinoka@chromium.org, Feb 15 2017

 Issue 692309  has been merged into this issue.
Please just always put a timezone rather than "local time". "local time" doesn't mean anything, it is never clear who the "local" is? Is it local to the bot, local to the appengine app, the browser, the user's preferences, who!?

"US/Pacific", "PDT" or "+10:00" is clearer and exact.

Comment 8 by hinoka@chromium.org, Feb 15 2017

Unfortunately we can't derive the exact timezone name from the browser, but +10:00 is doable.
I personally prefer +/-<amount> as you then don't have to look up the offset :-)
Done. CL and tainted versions are updated.
Status: Fixed (was: Assigned)

Sign in to add a comment