pango-view and pango-querymodules are gone |
|||||||
Issue descriptionChrome Version: ToT M58 What steps will reproduce the problem? (1) Start power wash What is the expected result? See messages What happens instead? Screen is black pango is removed in https://chromium-review.googlesource.com/#/c/431908/ . However, there are lots of boot-time and factory services pending on pango-view script to prepare and render screen. For example, all boot time messages (todev / tonorm transition, repair, power wash, legacy firmware update, ...) are all using pango-view ( http://gerrit.chromium.org/gerrit/8611 ). Factory wiping also uses pango-querymodule ( https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/gooftool/wipe.py#179 ) then pango-view to prepare the wiping messages. If pango must be removed from release image, we need an alternative for rendering text into an image file (for frecon and other process to render).
,
Feb 13 2017
What package calls pango-view? Is it missing a runtime dependency on the pango package? I only removed chromeos-chrome's dependency on it, so it probably shouldn't have disappeared if dependencies were specified correctly.
,
Feb 13 2017
,
Feb 13 2017
Uploaded https://chromium-review.googlesource.com/c/441117/ to add a dependency to common-assets. Is there a factory package that needs similar treatment?
,
Feb 14 2017
Re#2: So you are ok with pangi-* still living in system? I was wondering if your goal is to eliminate pango from base image. If pango is ok to keep, then it's very easy to solve. As you have made changes to 441117, I can also change the factory packages for it. Thanks!
,
Feb 14 2017
P.S: After looking at source, factory code was made to allow display_boot_message to run, not using pango directly; so I think your 441117 is all what we need. (There are some other dead factory code using pango directly but I believe we can delete them)
,
Feb 14 2017
I'd love to still remove our use of pango, cairo, glib, etc., since it's weird to ship graphics libraries that aren't used by Chrome, and since glib is a poor choice for C++ code when we have STL and libchrome available. I don't want to break stuff while figuring out how to do that, though, and we need to specify dependencies correctly so that it doesn't happen inadvertently. If you already know which factory packages need to be updated, please do it. :-) (To the bigger question of how to remove pango, maybe it'd be possible to build a small binary that uses Skia to render these messages. I'll save that for another bug, though.)
,
Feb 14 2017
Re#8 Yes I agree. I think you just need to make sure display_boot_message is working fine then factory code will be good (or at least just few minor changes) (Even better if your new approach can provide an approach for showing a list of all its runtime dependency since factory code was trying to copy the files into a tmpfs for wiping - and that's why we invoked pango-querymodules)
,
Feb 15 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hungte@chromium.org
, Feb 13 2017