New issue
Advanced search Search tips

Issue 691451 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Protobuf imports with partial paths are not checked for missing dependencies.

Project Member Reported by rhalavati@chromium.org, Feb 13 2017

Issue description

The current dependency checker for protobufs ignores partial dependencies as correctly checking them requires parsing the build scripts ( http://crbug.com/684383 ).

To resolve this problem, all protobuf imports throughout the Chrome code should be replaced with complete paths that start from src. 
 
Description: Show this description
Description: Show this description
Description: Show this description

Comment 4 by xyzzyz@chromium.org, Feb 13 2017

You also mentioned some issue with duplicate symbols due to different import path. Could you also clarify here what was this is about?

Comment 5 by xyzzyz@chromium.org, Feb 13 2017

Owner: rhalavati@chromium.org
One can set the output folder of the proto compilation (proto_out_dir switch in proto_library) to another folder and create extra compilation of one proto file, and import/include these compilations.

To solve this, we need to analyze the BUILD.gn files as well to find out the required dependencies.
Status: Assigned (was: Untriaged)

Sign in to add a comment