Disabling https://codereview.chromium.org/2689193002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2ce8436e8687f243389f203804c8e078f7fbb2

commit 8d2ce8436e8687f243389f203804c8e078f7fbb2
Author: tyoshino <tyoshino@chromium.org>
Date: Mon Feb 13 11:21:32 2017

Disable FileSystemProviderApiTest.ReadFile

TBR=mtomasz@chromium.org
BUG= 691449 

Review-Url: https://codereview.chromium.org/2689193002
Cr-Commit-Position: refs/heads/master@{#449931}

[modify] https://crrev.com/8d2ce8436e8687f243389f203804c8e078f7fbb2/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc

 Issue 691483  has been merged into this issue.

This is still flaky on ChromiumOS as of commit position #449954, even though the patch in #2 landed as #449931 and must have cycled already.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/33595

Upon inspecting your CL, it seems that you have disabled it everywhere *except* ChromiumOS :)

According to FindIt, the culprit may be https://codereview.chromium.org/2682163002, but I am not an expert in this code, therefore didn't proceed with the revert.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54520ce5e56cd898668f0f86172cdeb9914a9b71

commit 54520ce5e56cd898668f0f86172cdeb9914a9b71
Author: msramek <msramek@chromium.org>
Date: Mon Feb 13 16:08:50 2017

Fix disabling of FileSystemProviderApiTest.ReadFile

In https://codereview.chromium.org/2689193002, this test was disabled
everywhere except ChromeOS. Instead, it should have been disabled on
ChromiumOS.

NOTRY=True
TBR=mtomasz@chromium.org
BUG= 691449 

Review-Url: https://codereview.chromium.org/2692003002
Cr-Commit-Position: refs/heads/master@{#449968}

[modify] https://crrev.com/54520ce5e56cd898668f0f86172cdeb9914a9b71/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc

This is terrible. The file contents read via FSP API are corrupted.

@tyoshino: I tried the link you posted:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=FileSystemProviderApiTest.ReadFile

but it doesn't contain any flakes. I guess it's because the test has been disabled. Is there any way to get older flakes?

Some flakes will be recorded here: http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJGaWxlU3lzdGVtUHJvdmlkZXJBcGlUZXN0LlJlYWRGaWxlDA.

So far I can't reproduce the flakiness locally.

And... just reproduced.

The calls on JS side appear to arrive in a different order on the C++ side. This sounds very very dangerous. I'll take a look at it closer tomorrow.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3499037df8da2c29581bb74f1a3c252921432b0

commit d3499037df8da2c29581bb74f1a3c252921432b0
Author: mtomasz <mtomasz@chromium.org>
Date: Tue Feb 28 10:55:46 2017

Restore FSP API's read tests.

The CL regressing this test is reverted. See: crbug.com/2682163002

TBR=benwells
TEST=Test passes.
BUG= 691449 

Review-Url: https://codereview.chromium.org/2708333002
Cr-Commit-Position: refs/heads/master@{#453567}

[modify] https://crrev.com/d3499037df8da2c29581bb74f1a3c252921432b0/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc

[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.

No need for merge. The logic is fixed in a separate CL.