New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691445 link

Starred by 4 users
Status: Fixed
Merged: issue 652028
Owner:
tapted@chromium.org
Closed: Feb 2017
Cc:
█ spqc...@chromium.org
nyerramilli@chromium.org
tapted@chromium.org
█ msrchandra@chromium.org
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 603386



Sign in to add a comment

Harmony: Site settings bubble for chrome:// pages is badly aligned.

Project Member Reported by tapted@chromium.org, Feb 13 2017 
Chrome Version       : 57.0.2984.0

Affects Mac + Windows/Views

What steps will reproduce the problem?
1. --secondary-ui-md
2. Go, e.g., to chrome://flags
3. Click the "Chrome" icon where the padlock usually is

What is the expected result?

Alignment nice


What happens instead of that?

Alignment bad
Screen Shot 2017-02-13 at 2.16.29 pm.png
20.5 KB View Download

Comment 1 by tapted@chromium.org, Feb 13 2017 

Fix on Windows. Also before/after for non-MD.
harmony-windows-after.png
31.4 KB View Download
non-harmony-windows-before.png
34.4 KB View Download
non-harmony-windows-after.png
29.0 KB View Download

Comment 2 by tapted@chromium.org, Feb 13 2017 

Mac screenshots. CL is https://codereview.chromium.org/2693833002/
harmony-mac-before.png
30.8 KB View Download
harmony-mac-after.png
27.5 KB View Download

Comment 3 by tapted@chromium.org, Feb 13 2017

Blocking: 603386
Labels: -Pri-3 Phase3 Pri-2

Comment 4 by tapted@chromium.org, Feb 13 2017

Mergedinto: 652028
Status: Duplicate (was: Started)
Looking at the spec on  Issue 513479 , it looks like we want the Chrome icons to be aligned vertically, so I can't just delete the code :/

The harmony spec at https://docs.google.com/presentation/d/1NCYvxQ8VWuDDIK1uTiOL6zXQ1H0fJEoKxTivG8NIFVg/edit#slide=id.g1174d85ade_0_0 has us just deleting the logo from the bubble.

There's a bug for this already -  http://crbug.com/652028 

So https://codereview.chromium.org/2693833002/ should be incorporated into that (i.e. the logo should also be hidden under harmony when fixing this)

Comment 5 by tapted@chromium.org, Feb 23 2017

Status: Started (was: Duplicate)
reopening per https://codereview.chromium.org/2693833002/#msg2

Comment 6 by tapted@chromium.org, Feb 24 2017

Cc: spqc...@chromium.org msrchandra@chromium.org tapted@chromium.org shrike@chromium.org nyerramilli@chromium.org
 Issue 665385  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28ad54cb961a743161398564f4f1f97ded3b2350

commit 28ad54cb961a743161398564f4f1f97ded3b2350
Author: tapted <tapted@chromium.org>
Date: Fri Feb 24 01:24:53 2017

Don't offset chrome:// page security bubbles.

It breaks the alignment logic under Harmony, and makes the alignment
inconsistent with regular bubbles under non-Harmony.

Note under non-Harmony, the Chrome icon in the bubble will no longer be
directly below the Chrome icon in the Omnibox. This is intentional.

Under Harmony, the icon in the bubble is going away.

BUG= 691445 

Review-Url: https://codereview.chromium.org/2693833002
Cr-Commit-Position: refs/heads/master@{#452707}

[modify] https://crrev.com/28ad54cb961a743161398564f4f1f97ded3b2350/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Comment 8 by tapted@chromium.org, Feb 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment