Regression: 'chrome://history/syncedTabs' page appears distorted and 'Sign in' button on Chrome://history does not appear properly
Reported by
jshan...@etouch.net,
Feb 13 2017
|
||||
Issue descriptionChrome Version: 58.0.3010.0 (Official Build) b0d6dc9fc0c9ad8b4944fa48125ad5bcf3f29146-refs/heads/master@{#449855} OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12) Steps: !. Launch Chrome and navigate to chrome://history 2. Sign in with valid credentials and observe Actual: 'Tabs from other devices' and 'Sign in' button on Chrome://history page does not appear properly Expected: Tabs from other devices and Sign in button on Chrome://history page should be seen properly This is a regression issue, broken in M-58 series, will soon update other info
,
Feb 13 2017
Able to reproduce the issue and below are the bisect details obtained using bisect-per revision: Bisect Details: =============== Good build: 58.0.3009.0 Bad build: 58.0.3010.0 Bisect URL: https://chromium.googlesource.com/chromium/src/+log/77aa1a3c7c75269bf904d4d447cee5b7052120e2..9b40cc378411af0dccf39b5ab74137ae8ac7ea69 Change Log: https://chromium.googlesource.com/chromium/src/+/9b40cc378411af0dccf39b5ab74137ae8ac7ea69 @calamity: Assigning to you, request you to please take a look into it. Adding blocker label, please undo if not the case. Thanks.!
,
Feb 15 2017
noticed this today also Shall I revert https://codereview.chromium.org/2670723002?
,
Feb 16 2017
Looking into it. I'll revert if I can't figure out something by EOD.
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/304a22faf3a175594c3958906eca6dd8833cb1c7 commit 304a22faf3a175594c3958906eca6dd8833cb1c7 Author: calamity <calamity@chromium.org> Date: Fri Feb 17 04:34:26 2017 [MD WebUI] Polymer-CSS-Build across all bundles. This CL makes the vulcanize GN build able to process multiple bundles when running Polymer-CSS-Build. This was causing styles to be missing in MD History because they were not getting inlined. BUG= 691436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2698143003 Cr-Commit-Position: refs/heads/master@{#451210} [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/BUILD.gn [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/resources/md_downloads/BUILD.gn [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/resources/md_history/BUILD.gn [add] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/resources/polymer_css_build_gn.py [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/resources/vulcanize.gni [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/chrome/browser/resources/vulcanize_gn.py [modify] https://crrev.com/304a22faf3a175594c3958906eca6dd8833cb1c7/third_party/node/node.py
,
Feb 19 2017
,
Feb 20 2017
,
Feb 20 2017
,
Feb 21 2017
Tested the issue on Windows-7, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3018.0 as per the comment #0. Observed that the fix is working as expected. Attaching the screenshots for reference. Hence, adding the verified labels. Thanks. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jshan...@etouch.net
, Feb 13 2017Summary: Regression: 'chrome://history/syncedTabs' page appears distorted and 'Sign in' button on Chrome://history does not appear properly (was: Regression: 'Tabs from other devices' appears distorted and 'Sign in' button on Chrome://history page does not appear properly)
79.5 KB
79.5 KB View Download
158 KB
158 KB View Download