New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691428 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Bandwidth throttling - behavior when the values are unset and throttling is enabled

Project Member Reported by sduraisamy@chromium.org, Feb 13 2017

Issue description

When testing bandwidth throttling with management console (CPanel), I observed the following -

* Enable network throttling and set the download and upload speed as 1024 kbps
* The device throttles the network bandwidth to 1024 kbps (Expected)
* Empty the values for download and upload speed (according to CPanel ENG, the values are unset)
* Device gets the policy values as 0 for both download and upload speeds and throttling is set to true ("enabled":true)
* The device still throttles the network bandwidth to 1024 kbps (Expected: no throttling)
* Disable network throttling in CPanel
* The device is not throttling the bandwidth
* Enable network throttling in CPanel and do not set values for upload and download speed
* The device is not throttling the bandwidth

Workaround: I have asked CPanel ENG to not accept empty values for download and upload speeds
 

Comment 1 by kirtika@google.com, Feb 13 2017

Good catch, in your second scenario, when both speeds are 0 the code-path will return doing nothing. 
But this won't undo the current setting (1024 kbps), which is why you still see the throttling. In all fairness, I am not sure I can "fix" this, since your second command still had "throttling enabled". A fix would mean coding up "throttling enabled + both speeds 0 = disable throttling" instead of "throttling enabled + both speeds 0 = do nothing and return"
 

Once we make changes to CPanel UI to not accept empty values for download and upload speeds, I think we should be good.

Zhanlu, please update this bug when you make changes to CPanel UI. We can then probably close this bug.
Owner: zhanlu@chromium.org
Status: Fixed (was: Assigned)
This issue is already fixed. We now enforce admins to set a value if the throttling is enabled. For existing customers who have the policy enabled but no value set, an error will popup when the admin tries to save any policy change.
Cc: mlight@chromium.org

Comment 6 by mlight@chromium.org, Mar 22 2017

Owner: mlight@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment