New issue
Advanced search Search tips

Issue 691425 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webaudio/Oscillator/oscillator-late-start.html is flaky

Project Member Reported by tyoshino@chromium.org, Feb 13 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98

commit a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98
Author: hongchan <hongchan@chromium.org>
Date: Mon Feb 13 23:55:26 2017

Fix flakiness in webaudio/Oscillator/oscillator-late-start.html

This test uses a hacky method to trigger a function after the render
starts on OfflineAudioContext. This CL replaces such method of using
'onstatechange' with the suspension of OfflineAudioContext.

BUG= 691425 
TEST=
webaudio/Oscillator/oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2693853004
Cr-Commit-Position: refs/heads/master@{#450158}

[modify] https://crrev.com/a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start-expected.txt
[modify] https://crrev.com/a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
[modify] https://crrev.com/a8b78a341cd4b8d3aff4a4a6ba0011c6abf45f98/third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js

Labels: -Hotlist-Sheriff-Chromium
Status: Fixed (was: Assigned)
Thanks. I confirmed that it's no longer flaky on the dashboard.
Status: Verified (was: Fixed)
tyoshino@ Thanks for catching this!

Sign in to add a comment