New issue
Advanced search Search tips

Issue 691418 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Round-caps line segments is not drawn as a convex shape

Reported by xiangze....@intel.com, Feb 13 2017

Issue description

Skia draws round-caps line segments as a concave shape so skia GPU backend will not use convex path renderer, which is faster. 

I tried to make the shape convex by changing the control points of the line segments a little. The performance is much better. The score of MotionMark Basic Canvas Suite - "Canvas line segments, round caps" subcase will nearly triple from my experiment.

The benchmark can be found here: http://browserbench.org/MotionMark/developer.html

My change is in this CL: https://codereview.chromium.org/2691843003. It's hacky and I think a better way is needed.

 

Comment 1 by ajha@chromium.org, Nov 2 2017

Components: Internals>Skia
Labels: TE-NeedsTriageHelp
Adding proper component for someone from the respective team to have a look into the proposed CL.
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 2

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment