New issue
Advanced search Search tips

Issue 691415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MenuControllerTest.HostReceivesInputBeforeDestruction is failing on Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by tyoshino@chromium.org, Feb 13 2017

Issue description

Labels: -Sheriff-Chromium
https://codereview.chromium.org/2684993009 has been reverted by https://codereview.chromium.org/2690013002/

Removing Sheriff-Chromium label
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e51965aae5623c4d16975578802caf7b3c8ac9

commit 99e51965aae5623c4d16975578802caf7b3c8ac9
Author: jonross <jonross@chromium.org>
Date: Wed Feb 22 15:20:08 2017

Reland Stop MenuItemView from directly caching MenuController

This relands a change reviewed in: https://codereview.chromium.org/2684993009
With an update to the unittest to fix a memory leak that was only within the
test.

Revert "Revert of Stop MenuItemView From Directly Caching MenuController (patchset #1 id:1 of https://codereview.chromium.org/2684993009/ )"

This reverts commit b18851a60fd1a0820c00185bd660fc52bec31648.

TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
BUG= 691415 

Review-Url: https://codereview.chromium.org/2710663004
Cr-Commit-Position: refs/heads/master@{#452055}

[modify] https://crrev.com/99e51965aae5623c4d16975578802caf7b3c8ac9/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/99e51965aae5623c4d16975578802caf7b3c8ac9/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/99e51965aae5623c4d16975578802caf7b3c8ac9/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/99e51965aae5623c4d16975578802caf7b3c8ac9/ui/views/controls/menu/menu_item_view.h
[modify] https://crrev.com/99e51965aae5623c4d16975578802caf7b3c8ac9/ui/views/controls/menu/submenu_view.cc

Status: Fixed (was: Started)

Sign in to add a comment