New issue
Advanced search Search tips

Issue 691314 link

Starred by 2 users
Status: Assigned
Owner:
xhw...@chromium.org
Cc:
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

EME browser tests: Only report NOTSUPPORTEDERROR when promise is rejected with NotSupportedError

Project Member Reported by ddorwin@chromium.org, Feb 12 2017 
eme_player_js/player_utils.js fails the tests with `NOTSUPPORTEDERROR` if requestMediaKeySystemAccess() fails for any reason [1].

For correctness, this should only be reported if the promise is rejected with NotSupportedError.

To ensure the reason is not detectable by the application (i.e. issue 691290), we should also check (case-sensitively) the message attribute of the DOMException.

[1] https://cs.chromium.org/chromium/src/media/test/data/eme_player_js/player_utils.js?type=cs&q=NOTSUPPORTEDERROR&sq=package:chromium&l=171

Comment 1 by xhw...@chromium.org, Feb 13 2017 

Shall we always use the same message for NotSupportedError?

Today we at least have "None of the requested configurations were supported" and "Unsupported keySystem". The former is useful for web developers, but will make it easier to detect reasons that we don't want to expose.

Comment 2 by ddorwin@chromium.org, Feb 13 2017 

Probably. Having different messages might expose whether a request to use a key system was blocked and how. It could also vary as we change where and how the implementation checks various settings.

If the intent is to help developers, Blink supports supplying a different message to the dev tools console than the one the application gets.

Comment 3 by xhw...@chromium.org, Feb 13 2017 

> If the intent is to help developers, Blink supports supplying a different message to the dev tools console than the one the application gets.

Do you have examples on this? I like this idea.

Comment 4 by xhw...@chromium.org, Oct 23 2017

Cc: jrumm...@chromium.org
Owner: xhw...@chromium.org

Comment 5 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
►

Sign in to add a comment