New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691313 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] The initial state of the presentation connection should be "connecting"

Project Member Reported by zhaobin@chromium.org, Feb 12 2017

Issue description

Web platform test PresentationRequest_onconnectionavailable-manual.html fails with 1-ua URL. Error message:

assert_equals: The initial state of the presentation connection is "connecting". expected "connecting" but got "connected"
    at http://127.0.0.1:57272/presentation-api/controlling-ua/PresentationRequest_onconnectionavailable-manual.html:49:17
    at <anonymous>
 

Comment 1 Deleted

Fixing this may affect  crbug.com/684664 . Need to verify both bugs are fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0

commit f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0
Author: zhaobin <zhaobin@chromium.org>
Date: Tue Feb 14 22:41:24 2017

[Presentation API] Remove state transition from PresentationConnection::take()

PresentationConnection should have initial state "connecting". Remove state transition from PresentationConnection::take() to fix web platform tests.

BUG= 691313 

Review-Url: https://codereview.chromium.org/2691773002
Cr-Commit-Position: refs/heads/master@{#450497}

[modify] https://crrev.com/f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0/third_party/WebKit/LayoutTests/presentation/presentation-start.html
[modify] https://crrev.com/f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Comment 4 by sko...@chromium.org, Feb 16 2017

Status: Assigned (was: Untriaged)
Bin, is this fixed?
Status: Fixed (was: Assigned)

Sign in to add a comment