New issue
Advanced search Search tips

Issue 691311 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

One navigation is missing from back navigation list if pending item is displayed

Project Member Reported by eugene...@chromium.org, Feb 12 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): M56, M57, M58
iOS Version: All
Device: All

Steps to reproduce: 
1.) Load badssl.com
2.) Tap Expired
3.) Long press on Back button

Observed behavior: 
Only New Tab Entry is displayed

Expected behavior: 
badssl.com should be in backwards item list


 

Comment 1 by danyao@chromium.org, Apr 24 2017

Owner: danyao@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a346dfe7ace9e2e9cf60ff07a43e2811e513d150

commit a346dfe7ace9e2e9cf60ff07a43e2811e513d150
Author: danyao <danyao@chromium.org>
Date: Wed Apr 26 22:07:52 2017

Fix missing back navigation item when pending item is displayed.

Current back navigation list assumes that the visible item is the last
committed item. This causes the most recently committed item to be
missing from the back navigation list when an interstitials is
displayed. This change fixes this buggy behavior.

R=eugenebut@chromium.org
BUG= 691311 
TESTED=Tested in simulator. Also added unit tests to ios_web_unittests.

Review-Url: https://codereview.chromium.org/2838003002
Cr-Commit-Position: refs/heads/master@{#467477}

[modify] https://crrev.com/a346dfe7ace9e2e9cf60ff07a43e2811e513d150/ios/web/navigation/crw_session_controller.mm
[modify] https://crrev.com/a346dfe7ace9e2e9cf60ff07a43e2811e513d150/ios/web/navigation/crw_session_controller_unittest.mm

Comment 3 by danyao@chromium.org, Apr 26 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified the issue on the latest build 60.0.3087.0 canary tested on iPad Air.
badssl is displayed on long tapping on back arrow, works fine.

Sign in to add a comment