clang-cl doesn't understand /X flag |
||
Issue descriptionhttps://msdn.microsoft.com/en-us/library/93t31bx4.aspx "Prevents the compiler from searching for include files in directories specified in the PATH and INCLUDE environment variables." (i'd file that in llvm.org/bugs but that's currently down) Not super important, but seems like something we'd want to use in the chrome build so that we only use -imsvc flags I think.
,
Feb 28 2018
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0791537dfea21935e71c9533d72f3b1309408cb commit c0791537dfea21935e71c9533d72f3b1309408cb Author: Nico Weber <thakis@chromium.org> Date: Wed Apr 04 13:00:11 2018 win/clang: Pass /X to the compiler. This tells the compiler to not look in various env vars (e.g. %INCLUDE%) which makes the build slightly more hermetic. (MSVC still uses the env files to get at %INCLUDE% so we can't pass /X to cl, but clang-cl gets all system include dirs passed as -imsvc flags instead.) Also move /utf-8 from the warnings config to the compiler config as it's not a warning flag. Bug: 691286 Change-Id: I5306d33bbfacd03a267b9d1c082297a26aadf9b8 Reviewed-on: https://chromium-review.googlesource.com/993552 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548030} [modify] https://crrev.com/c0791537dfea21935e71c9533d72f3b1309408cb/build/config/compiler/BUILD.gn
,
Apr 4 2018
clang-cl doesn't just understand the flag now, we now even use it as part of the build. |
||
►
Sign in to add a comment |
||
Comment 1 by dtapu...@chromium.org
, Nov 10 2017