New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691254 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 677827
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Need to hit Enter TWO additional times after autocomplete (total three) in order to send a form

Reported by teo8...@gmail.com, Feb 11 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
Preparation:

1. visit http://output.jsbin.com/muyahababe
2. enter "foo bar" into the text field and submit the form

Actual test:

3. go back to http://output.jsbin.com/muyahababe
4. Type "fo", wait for the autocomplete suggestions to appear
5. hit the down arrow key to select the first suggestion (e.g. "foo bar") and hit Enter once to confirm it. The selected text gets copied into the input field
6. hit Enter again

What is the expected behavior?
The first hit of the Enter key only confirms the selected autocomplete suggestion and copies it into the text field, without sending the form. That is kind of questionable but it does make sense, and it's the way autocomplete works.

The second hit to the Enter key (when the autocompleted text is already copied in its entirety into the text field) should actually send the form.

What went wrong?
The second keystroke on the Enter key does NOTHING.
You have to hit Enter a third time in order to send the form.

Did this work before? Yes not sure, not long ago

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 24.0 r0

 

Comment 1 by je...@jenanwise.com, Feb 11 2017

This appears to be a specific case of the more general 691292.
Labels: Needs-Triage-M56
Labels: -Pri-2 -Needs-Triage-M56 ReleaseBlock-Stable M-57 hasbisect OS-Mac Pri-1
Owner: foolip@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.2 and Ubuntu 14.04 using reported version #56.0.2924.87 but the same is not reproducible in the latest canary #58.0.3011.4.

Issue is not reproducible on Win OS.

Reverse Bisect Information:
=====================
Good build: 57.0.2987.11
Bad Build : 57.0.2987.10

The issue was found broken in the M57 branch builds. Hence, getting CL from Omahaproxy which is as follows:

Change Log URL (From Omahaproxy): 
https://chromium.googlesource.com/chromium/src/+log/57.0.2987.10..57.0.2987.11?pretty=fuller&n=10000

From the above change log possible CL that fixed this issue:

Review-Url: https://codereview.chromium.org/2644843004

foolip@ - Could you please check and merge the fix to M57 if it is a valid candidate.

Note: Adding label ReleaseBlock-Stable, as it is a recent regression.

Thanks...!!

Comment 4 by foolip@chromium.org, Feb 15 2017

This was already merged to M57 in https://chromium.googlesource.com/chromium/src.git/+/69e39c484ec2f1f3b7320f07f43fd0724b6cb382, so it should not reproduce on the current Chrome beta 57.0.2987.37, can you confirm?

Unfortunately it was too late to merge it to M56, due to my misreading of the issue, so we may see some reports like this until M57 is released.
Cc: ranjitkan@chromium.org
Labels: TE-Verified-57.0.2987.54 TE-Verified-M57
Rechecked this on chrome version 57.0.2987.54 on MAC 10.12.2 and Ubuntu 14.04. Fix is working as intended. The first hit of the Enter key only confirms the selected autocomplete suggestion and copies it into the text field and the second hit sends the form.

Adding TE-Verified labels

Comment 6 by foolip@chromium.org, Feb 16 2017

Mergedinto: 677827
Status: Duplicate (was: Assigned)
Thanks #5, marking this as a duplicate of  issue 677827 .

Sign in to add a comment