New issue
Advanced search Search tips

Issue 691200 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 388681



Sign in to add a comment

TextControlElement::indexForVisiblePosition() should use EphemeralRange

Project Member Reported by yosin@chromium.org, Feb 11 2017

Issue description

EphemralRange is ennough for TextControlElement::indexForVisiblePosition().
 

Comment 1 by yosin@chromium.org, Feb 11 2017

Labels: Hotlist-GoodFirstBug

Comment 2 by tkent@chromium.org, Feb 12 2017

Labels: -Type-Bug Hotlist-CodeHealth Type-Task

Comment 3 by yosin@chromium.org, Mar 2 2017

Owner: yosin@chromium.org
Status: Started (was: Available)
I take this.

Comment 4 by yosin@chromium.org, Mar 2 2017

In review: http://crrev.com/2727923002
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ed48423a76851451298d54a5260cc30503fa1d

commit 99ed48423a76851451298d54a5260cc30503fa1d
Author: yosin <yosin@chromium.org>
Date: Fri Mar 03 01:51:48 2017

Make TextControlElement::indexForVisiblePosition() not to use temporary Range

This patch makes |TextControlElement::indexForVisiblePosition()| to call
|TextIterator::rangeLength()| without using temporary |Range| object to avoid
registering temporary |Range| object into register update list to reduce memory
usage an relocation cost for improving code halth.

BUG= 691200 
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2727923002
Cr-Commit-Position: refs/heads/master@{#454461}

[modify] https://crrev.com/99ed48423a76851451298d54a5260cc30503fa1d/third_party/WebKit/Source/core/html/TextControlElement.cpp

Comment 6 by yosin@chromium.org, Mar 6 2017

Status: Fixed (was: Started)

Sign in to add a comment