FormatBlockCommand::elementForFormatBlockCommand() should take EphemeralRange |
||||
Issue descriptionEphemeralRange is enough for FormatBlockCommand::elementForFormatBlockCommand(). There is only one call site: - valueFormatBlock() in "Editor.cpp"
,
Mar 2 2017
I take this.
,
Mar 2 2017
In review: http://crrev.com/2729823002
,
Mar 6 2017
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b66326f26629d4e161ad020ea34052c3f52598af commit b66326f26629d4e161ad020ea34052c3f52598af Author: yosin <yosin@chromium.org> Date: Thu Mar 09 06:35:28 2017 Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take |EphemeralRange| instead of |Range| object to avoid registering temporary |Range| object to range update list to reduce memory usage and relocation cost for improving code health. BUG= 691199 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2729823002 Cr-Commit-Position: refs/heads/master@{#455681} [modify] https://crrev.com/b66326f26629d4e161ad020ea34052c3f52598af/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [modify] https://crrev.com/b66326f26629d4e161ad020ea34052c3f52598af/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp [modify] https://crrev.com/b66326f26629d4e161ad020ea34052c3f52598af/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
,
Mar 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yosin@chromium.org
, Feb 11 2017