TextControlElement::selection() should return SelectionInDOMTree |
|||||||
Issue description|TextControlElement::selection()| is called only by Editor::selectionForCommand() and returned |Range| is used for constructing |EphemeralRange|. Thus we should make |TextControlElement::selection()| to return |EphemeralRange|.
,
Feb 11 2017
,
Feb 11 2017
,
Feb 11 2017
,
Feb 12 2017
,
Mar 10 2017
Can i take this up ?
,
Mar 10 2017
tanvir.rizvi@, yes please. Thanks for taking this. BTW, You don't need to ask, just say "I take this." and start working. yosin@ is a virtual owner. tanvir.rizvi@ works this.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ae803e5499bf5cc3104f06152b491b59668f88 commit e3ae803e5499bf5cc3104f06152b491b59668f88 Author: tanvir.rizvi <tanvir.rizvi@samsung.com> Date: Thu Mar 16 06:50:38 2017 TextControlElement::selection() should return SelectionInDOMTree. Currently |TextControlElement::selection()| is called only by Editor::selectionForCommand() and returned |Range| is used for constructing |EphemeralRange|, which again is used for constructing |SelectionInDOMTree|. This CL makes |TextControlElement::selection()| to return |SelectionInDOMTree| and avoid creation of Range. BUG= 691193 Review-Url: https://codereview.chromium.org/2750833002 Cr-Commit-Position: refs/heads/master@{#457367} [modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/html/TextControlElement.cpp [modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/html/TextControlElement.h
,
Mar 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yosin@chromium.org
, Feb 11 2017