New issue
Advanced search Search tips

Issue 691193 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocking:
issue 388681



Sign in to add a comment

TextControlElement::selection() should return SelectionInDOMTree

Project Member Reported by yosin@chromium.org, Feb 11 2017

Issue description

|TextControlElement::selection()| is called only by Editor::selectionForCommand() and returned |Range| is used for constructing |EphemeralRange|. 

Thus we should make |TextControlElement::selection()| to return |EphemeralRange|.
 

Comment 1 by yosin@chromium.org, Feb 11 2017

Or SelectionInDOMTree to consider HTMLInputElement.selectionDirection.

Comment 2 by yosin@chromium.org, Feb 11 2017

Blocking: 388681

Comment 3 by yosin@chromium.org, Feb 11 2017

Labels: Hotlist-GoodFirstBug

Comment 4 by yosin@chromium.org, Feb 11 2017

Summary: TextControlElement::selection() should return SelectionInDOMTree (was: TextControlElement::selection() should return EphemeralRange)

Comment 5 by tkent@chromium.org, Feb 12 2017

Labels: -Type-Bug Hotlist-CodeHealth Type-Task
Can i take this up ?

Comment 7 by yosin@chromium.org, Mar 10 2017

Owner: yosin@chromium.org
Status: Started (was: Available)
tanvir.rizvi@, yes please. Thanks for taking this.

BTW, You don't need to ask, just say "I take this." and start working.

yosin@ is a virtual owner. tanvir.rizvi@ works this.

Comment 8 Deleted

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3ae803e5499bf5cc3104f06152b491b59668f88

commit e3ae803e5499bf5cc3104f06152b491b59668f88
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Thu Mar 16 06:50:38 2017

TextControlElement::selection() should return SelectionInDOMTree.

Currently |TextControlElement::selection()| is called
only by Editor::selectionForCommand()
and returned |Range| is used for constructing |EphemeralRange|,
which again is used for constructing |SelectionInDOMTree|.

This CL makes |TextControlElement::selection()|
to return |SelectionInDOMTree| and avoid creation of Range.

BUG= 691193 

Review-Url: https://codereview.chromium.org/2750833002
Cr-Commit-Position: refs/heads/master@{#457367}

[modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/e3ae803e5499bf5cc3104f06152b491b59668f88/third_party/WebKit/Source/core/html/TextControlElement.h

Comment 10 by yosin@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Sign in to add a comment