"PaymentRequestCreditCardEditorTest.EnteringValidData" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRQYXltZW50UmVxdWVzdENyZWRpdENhcmRFZGl0b3JUZXN0LkVudGVyaW5nVmFsaWREYXRhDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Failed in https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51955 but has been green after that on the "Linux Tests" bot. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=PaymentRequestCreditCardEditorTest
Issue 691257 has been merged into this issue.
Failed on Win7 Tests (1) https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29
+mathp who wrote the test and might know what's up.
Removing Hotlist-Sheriff-Chromium as the flakiness is not so high to require continued attention by the sheriffs.
Detected 3 new flakes for test/step "PaymentRequestCreditCardEditorTest.EnteringValidData". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRQYXltZW50UmVxdWVzdENyZWRpdENhcmRFZGl0b3JUZXN0LkVudGVyaW5nVmFsaWREYXRhDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Disabling on Win in https://codereview.chromium.org/2689323007/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30be9645b5e64776141f75ac551a28e454852d81 commit 30be9645b5e64776141f75ac551a28e454852d81 Author: perkj <perkj@chromium.org> Date: Thu Feb 16 10:39:02 2017 Disable flaky PaymentRequestCreditCardEditorTest.EnteringValidData on Win BUG= 691185 TBR=mathp@chromium.org Review-Url: https://codereview.chromium.org/2689323007 Cr-Commit-Position: refs/heads/master@{#450926} [modify] https://crrev.com/30be9645b5e64776141f75ac551a28e454852d81/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5 commit 0e33868f81c5c8a299e14c96b1ce6b49ce325ee5 Author: mathp <mathp@chromium.org> Date: Thu Feb 16 17:39:25 2017 [Payments] Add combobox support to editors. * Refactored the ValidationDelegate to support Textfield and Combobox. * Added the COMBOBOX type for editors to specify when returning field definitions. * Added a constructor to Combobox which takes ownership of its model. * Added new ValidatingCombobox type which validates on first blur and subsequent changes. * Re-enable flaky interactive_ui_tests PaymentRequest*CreditCard*Valid BUG= 687601 , 691185 TEST=CreditCardEditorViewController unit_tests, PaymentRequest* interactive_ui_tests Review-Url: https://codereview.chromium.org/2689363004 Cr-Commit-Position: refs/heads/master@{#451005} [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/app/generated_resources.grd [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/editor_view_controller.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/editor_view_controller.h [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/preselected_combobox_model.cc [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/preselected_combobox_model.h [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validating_combobox.cc [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validating_combobox.h [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validating_textfield.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validating_textfield.h [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validating_textfield_unittest.cc [add] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/browser/ui/views/payments/validation_delegate.h [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/chrome/test/BUILD.gn [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/0e33868f81c5c8a299e14c96b1ce6b49ce325ee5/ui/views/controls/combobox/combobox.h
Please use Sheriff-Chromium label instead of Hotlist-Sheriff-Chromium. Issues with Sheriff-Chromium label are shown in Sheriff-o-Matic and are tried by sheriffs directly.
Turns out search on Monorail is eventually consistent. Removing Sheriff-Chromium from this issue since Hotlist-Sheriff-Chromium was removed earlier.
Comment 1 by tyoshino@chromium.org
, Feb 13 2017Owner: anthonyvd@chromium.org
Status: Assigned (was: Untriaged)