New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691164 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 691133



Sign in to add a comment

Add ability to enable/disable url request blocking

Project Member Reported by allada@chromium.org, Feb 11 2017

Issue description

We should not depend on URL request entries to exist in order to block url requests in devtools network.
 

Comment 1 by allada@chromium.org, Feb 11 2017

Blocking: 691133
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c043f5f744262981becd3d45a79981ad3f6b67

commit 01c043f5f744262981becd3d45a79981ad3f6b67
Author: allada <allada@chromium.org>
Date: Fri Mar 10 04:09:32 2017

[Devtools] Added Enable/Disable for request blocking in network

* Added Enable/Disable button in network blocking drawer.
* Persists the network blocking entries between devtools reloads.
* Changed code to use setBlockedURLs instead of add/remove counterparts.
* Moved icon notifier from main to network module.

see: http://imgur.com/a/G0VFI

R=pfeldman
BUG= 691164 

Review-Url: https://codereview.chromium.org/2692653003
Cr-Commit-Position: refs/heads/master@{#455986}

[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-blocked-reason.html
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/01c043f5f744262981becd3d45a79981ad3f6b67/third_party/WebKit/Source/devtools/front_end/sdk/module.json

Comment 3 by allada@chromium.org, Mar 11 2017

Status: Fixed (was: Started)

Comment 4 by kayce@google.com, Apr 3 2017

Labels: DevTools-Release-Notes-Feature

Sign in to add a comment