New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691161 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

In deployment and/or repair_test, update firmware version with repair version

Reported by jrbarnette@chromium.org, Feb 11 2017

Issue description

During deployment_test and also with repair_test, the
command will, in many cases, update the stable repair version
for the selected board.  When it does this, if the new repair
build has new firmware, the firmware version must also be
updated.  Without that, DUTs may immediately begin failing
repair.

The script needs to change to include updating the firmware
to match any repair build change.

For an example of this happening, see here:
    https://b2/32162224
 

Comment 1 by aut...@google.com, Feb 15 2017

Owner: jrbarnette@chromium.org
assuming jrbarnette is working on this, assigning to him
Status: Started (was: Available)
This has been a factor in various deployment and repair cases
in recent weeks.  I'm close to a fix, so I'll try and wrap it
up this week before any _more_ bad things happen.

For reference, one recent bad event is bug 708285, which shows
how the symptoms typically play out.

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3031fa9a503ebb47f520d69c76fe6e19dbc304ed

commit 3031fa9a503ebb47f520d69c76fe6e19dbc304ed
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Apr 12 13:05:14 2017

[autotest] Export get_firmware_version.

This changes the assign_stable_images module to export the
`get_firmware_version()` function for outside callers.  The change
includes some refactoring to make the presented interface be usable.

BUG= chromium:691161 
TEST=dry run of assign_stable_versions

Change-Id: If8e993a70d3961240291150edda8c009b7de3996
Reviewed-on: https://chromium-review.googlesource.com/469148
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

[modify] https://crrev.com/3031fa9a503ebb47f520d69c76fe6e19dbc304ed/site_utils/stable_images/assign_stable_images.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3031fa9a503ebb47f520d69c76fe6e19dbc304ed

commit 3031fa9a503ebb47f520d69c76fe6e19dbc304ed
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Apr 12 13:05:14 2017

[autotest] Export get_firmware_version.

This changes the assign_stable_images module to export the
`get_firmware_version()` function for outside callers.  The change
includes some refactoring to make the presented interface be usable.

BUG= chromium:691161 
TEST=dry run of assign_stable_versions

Change-Id: If8e993a70d3961240291150edda8c009b7de3996
Reviewed-on: https://chromium-review.googlesource.com/469148
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

[modify] https://crrev.com/3031fa9a503ebb47f520d69c76fe6e19dbc304ed/site_utils/stable_images/assign_stable_images.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3031fa9a503ebb47f520d69c76fe6e19dbc304ed

commit 3031fa9a503ebb47f520d69c76fe6e19dbc304ed
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Apr 12 13:05:14 2017

[autotest] Export get_firmware_version.

This changes the assign_stable_images module to export the
`get_firmware_version()` function for outside callers.  The change
includes some refactoring to make the presented interface be usable.

BUG= chromium:691161 
TEST=dry run of assign_stable_versions

Change-Id: If8e993a70d3961240291150edda8c009b7de3996
Reviewed-on: https://chromium-review.googlesource.com/469148
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

[modify] https://crrev.com/3031fa9a503ebb47f520d69c76fe6e19dbc304ed/site_utils/stable_images/assign_stable_images.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/90c247d2124c2a9b9e56e5a0f8d0794cd3049849

commit 90c247d2124c2a9b9e56e5a0f8d0794cd3049849
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Apr 12 13:05:24 2017

[autotest] Move some code within assign_stable_images.

This moves some recently changed code to a new location within the
same file.

This change is made separate from the main change so as to simplify
review.

BUG= chromium:691161 
TEST=dry run of assign_stable_versions

Change-Id: I3eec591649df1ce69fa377d1a8ee26731fda496d
Reviewed-on: https://chromium-review.googlesource.com/469090
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

[modify] https://crrev.com/90c247d2124c2a9b9e56e5a0f8d0794cd3049849/site_utils/stable_images/assign_stable_images.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f7d33d0b5ff0697c4ec4028d14aead277408c439

commit f7d33d0b5ff0697c4ec4028d14aead277408c439
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Apr 12 13:05:34 2017

[autotest] Update deployment_test to handle firmware

This updates deployment_test and repair_test to automatically update
a board's firmware version as necessary when updating the stable
repair image.

BUG= chromium:691161 
TEST=repair_test --nostable --noinstall

Change-Id: Iec3a83223f124c6688d5cc26e10591c9592ddc72
Reviewed-on: https://chromium-review.googlesource.com/469149
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/f7d33d0b5ff0697c4ec4028d14aead277408c439/site_utils/deployment/install.py

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment