New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691152 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

MD system tray: Bluetooth: Metrics for the toggle of Bluetooth are not collected.

Project Member Reported by fukino@chromium.org, Feb 11 2017

Issue description

In the non-MD system tray, UMA_STATUS_AREA_BLUETOOTH_DISABLED and UMA_STATUS_AREA_BLUETOOTH_ENABLED are collected on the click on Bluetooth toggle button.
However, in MD system tray, they are not collected.
We should send UMA_STATUS_AREA_BLUETOOTH_DISABLED and UMA_STATUS_AREA_BLUETOOTH_ENABLED when the new toggle button is clicked.
 
Labels: Proj-MaterialDesign-CrOS M-57
If this is a simple low-risk change I think we should consider merging back to m-57.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e95bae2c160909c52b01b269f90c63f46ab9039a

commit e95bae2c160909c52b01b269f90c63f46ab9039a
Author: fukino <fukino@chromium.org>
Date: Fri Feb 17 06:06:59 2017

MD system tray: Add user metrics for clicks on the Bluetooth toggle switch.

In non-MD system tray, clicks on the Bluetooth toggle switch have been recorded.
However, in MD system tray, those clicks are not recorded.
This CL add the same metrics events in MD system tray as well.

BUG= 691152 
TEST=Open chrome://user-actions and check if StatusArea_Bluetooth_Enabled and
StatusArea_Bluetooth_Disabled are recorded when the toggle button is clicked
in MD Bluetooth menu.

Review-Url: https://codereview.chromium.org/2691053003
Cr-Commit-Position: refs/heads/master@{#451236}

[modify] https://crrev.com/e95bae2c160909c52b01b269f90c63f46ab9039a/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc

Comment 3 by fukino@chromium.org, Feb 17 2017

Labels: Merge-Request-57
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Let's hold off as marking as Fixed in 57 until the merge completes
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 20 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c62d676d968ece273b7954ea5137eaca0233a9

commit 65c62d676d968ece273b7954ea5137eaca0233a9
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Feb 20 04:10:10 2017

MD system tray: Add user metrics for clicks on the Bluetooth toggle switch.

In non-MD system tray, clicks on the Bluetooth toggle switch have been recorded.
However, in MD system tray, those clicks are not recorded.
This CL add the same metrics events in MD system tray as well.

BUG= 691152 
TEST=Open chrome://user-actions and check if StatusArea_Bluetooth_Enabled and
StatusArea_Bluetooth_Disabled are recorded when the toggle button is clicked
in MD Bluetooth menu.
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2691053003
Cr-Commit-Position: refs/heads/master@{#451236}
(cherry picked from commit e95bae2c160909c52b01b269f90c63f46ab9039a)

Review-Url: https://codereview.chromium.org/2708553002 .
Cr-Commit-Position: refs/branch-heads/2987@{#592}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/65c62d676d968ece273b7954ea5137eaca0233a9/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc

Comment 7 by fukino@chromium.org, Feb 22 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment