Issue 691141 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ chili@chromium.org Last visit 22 days ago
Closed:	Feb 2017
Cc:	█ dim...@chromium.org fgor...@chromium.org █ talo@chromium.org petewil@chromium.org
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Error pages should result in Loading Failed on background loader

Project Member Reported by chili@chromium.org, Feb 10 2017

Issue description

If the page navigation results in address unresolved or SSL or any of a big variety of pages, we should fail loading rather than load/save the actual error page.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91941581b49f242755c8246fb788ec2ceeee65bd

commit 91941581b49f242755c8246fb788ec2ceeee65bd
Author: chili <chili@chromium.org>
Date: Mon Feb 13 23:20:10 2017

[Offline pages] Add navigation error handling to background loader.

This ensures that we don't try to download any net error pages.

BUG= 691141 

Review-Url: https://codereview.chromium.org/2656763002
Cr-Commit-Position: refs/heads/master@{#450146}

[modify] https://crrev.com/91941581b49f242755c8246fb788ec2ceeee65bd/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/91941581b49f242755c8246fb788ec2ceeee65bd/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/91941581b49f242755c8246fb788ec2ceeee65bd/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Comment 2 by chili@chromium.org, Feb 13 2017

Status: Fixed (was: Started)

►

Issue 691141 link

Issue metadata

Error pages should result in Loading Failed on background loader

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

Comment 1 Deleted

Comment 2 by chili@chromium.org, Feb 13 2017

Comment 2 Deleted

Sign in to add a comment