Issue metadata
Sign in to add a comment
|
"Add this site to your shelf" appears in guest mode
Reported by
jleedev@gmail.com,
Feb 10 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS armv7l 9000.82.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Platform: 9000.82.0 (Official Build) stable-channel daisy Steps to reproduce the problem: 1. Browse as guest 2. Sign in to Google+ What is the expected behavior? What went wrong? "Add this site to your shelf to use it at any time" appears. It creates a useless icon in the shelf. Did this work before? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: 9000.82.0 Flash Version: Shockwave Flash 24.0 r0
,
Feb 15 2017
I was unable to reproduce this in 57.0.2987.19 (Official Build) dev (64-bit) @jleedev, if you go into Guest mode could you check if "Chrome menu > More tools > Add to shelf" is enabled or disabled?
,
Feb 15 2017
Yes, More tools > Add to shelf is disabled. I can actually reproduce this by signing in to cros in guest mode and entering plus.google.com, no need to sign in. I notice that the fix for Issue 456654 controls whether the menu item is disabled, but the code in chrome/browser/banners doesn't make such a check.
,
Feb 15 2017
And I don't currently have a chromebook on non-stable to verify.
,
Feb 16 2017
@tdanderson -- could you help route this to someone familiar with the "Add to shelf" banner? It seems like we should disable it in Guest mode since we already disable the wrench menu item.
,
Feb 16 2017
I did not know this existed. Evan, mind taking a look since I believe you recently re-implemented all of the browser infobars?
,
Feb 16 2017
heh, I definitely did not reimplement all of the browser infobars. Looks like this is [1] and is owned by dominickn [1] chrome/browser/banners/app_banner_manager_desktop.cc
,
Feb 16 2017
Doors guest mode use an off the record profile? If so this should be addressed in M57 (can verify this once I'm in office)
,
Feb 16 2017
https://codereview.chromium.org/2633603002 should fix this in M57. Closing this out, please re-open if you continue to see this. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zalcorn@chromium.org
, Feb 14 2017Status: Assigned (was: Unconfirmed)