Improper Counter metric constructor in get_crashdumps()
Reported by
jrbarnette@chromium.org,
Feb 10 2017
|
|||||
Issue description
This repair job:
http://cautotest/tko/retrieve_logs.cgi?job=/results/hosts/chromeos2-row7-rack7-host13/59883785-repair/
Failed because of this traceback:
Traceback (most recent call last):
File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 447, in _repair_host
self.repair(host)
File "/usr/local/autotest/server/hosts/cros_repair.py", line 282, in repair
crashcollect.get_crashinfo(host, None)
File "/usr/local/autotest/site-packages/chromite/lib/metrics.py", line 274, in wrapper
return fn(*args, **kwargs)
File "/usr/local/autotest/server/crashcollect.py", line 161, in get_crashinfo
get_crashdumps(host, test_start_time)
File "/usr/local/autotest/site-packages/chromite/lib/metrics.py", line 274, in wrapper
return fn(*args, **kwargs)
File "/usr/local/autotest/server/crashcollect.py", line 148, in get_crashdumps
get_site_crashdumps(host, test_start_time)
File "/usr/local/autotest/server/site_crashcollect.py", line 264, in get_site_crashdumps
minidumps = find_and_generate_minidump_stacktraces(host_resultdir)
File "/usr/local/autotest/server/site_crashcollect.py", line 147, in find_and_generate_minidump_stacktraces
generate_stacktrace_for_file(file, host_resultdir)
File "/usr/local/autotest/server/site_crashcollect.py", line 109, in generate_stacktrace_for_file
crashserver_name = _resolve_crashserver()
File "/usr/local/autotest/server/site_crashcollect.py", line 53, in _resolve_crashserver
fields={'crash_server': crashserver_name})
File "/usr/local/autotest/site-packages/chromite/lib/metrics.py", line 105, in wrapper
return fn(*args, **kwargs)
File "/usr/local/autotest/site-packages/chromite/lib/metrics.py", line 86, in AddToQueueIfPresent
return fn(*args, **kwargs)
TypeError: Counter() got an unexpected keyword argument 'fields'
The failing call is in server/site_crashcollect.py, in
_resolve_crashserver(). Here's the relevant call:
if not crashserver_name:
metrics.Counter('chromeos/autotest/crashcollect/could_not_resolve'
).increment()
raise dev_server.DevServerException(
'No crash server has the capacity to symbolicate the dump.')
else:
metrics.Counter('chromeos/autotest/crashcollect/resolved',
fields={'crash_server': crashserver_name})
`git blame` says this CL is at fault:
https://chromium-review.googlesource.com/#/c/413624/
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b30d0071bfe9d6d5835f7b6fc02c639c515ec6f2 commit b30d0071bfe9d6d5835f7b6fc02c639c515ec6f2 Author: Aviv Keshet <akeshet@chromium.org> Date: Wed Feb 15 23:45:02 2017 autotest: fix incorrect metrics call BUG= chromium:691119 TEST=None Change-Id: I0c19de0bccf00b7a8cd40e84ea527d3ec5854492 Reviewed-on: https://chromium-review.googlesource.com/442044 Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> Commit-Queue: Richard Barnette <jrbarnette@chromium.org> [modify] https://crrev.com/b30d0071bfe9d6d5835f7b6fc02c639c515ec6f2/server/site_crashcollect.py
,
Feb 15 2017
Issue 692280 has been merged into this issue.
,
Feb 15 2017
Issue 692353 has been merged into this issue.
,
Feb 16 2017
,
Mar 8 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jrbarnette@chromium.org
, Feb 10 2017