New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691110 link

Starred by 2 users
Status: Verified
Owner:
nya@chromium.org
Closed: Feb 2017
Cc:
█ rookrishna@chromium.org
weifangsun@chromium.org
sdantul...@chromium.org
fukino@chromium.org
abod...@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

media views all show "0 bytes available" in overflow menu

Project Member Reported by dhadd...@chromium.org, Feb 10 2017 
Check out the overflow menu of any Media View
It shows "0 bytes available" 

I think this could be confusing for some users as they may think they can't save any more images/videos.

Should we hide this for Media views?

Comment 1 by weifangsun@chromium.org, Feb 11 2017

Cc: fukino@chromium.org
Thanks for pointing this out!

Agreed - I think we should hide this item in the overflow menu, similar to how we handle a Dropbox addition for example or mounted archive file.

@nya, @fukino - Could you please assign to the right person? Thanks!

Comment 2 by nya@chromium.org, Feb 13 2017

Owner: nya@chromium.org
Status: Started (was: Untriaged)
Thanks! I will take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1824eba89c684de0b5fe91a013708caaafcf9081

commit 1824eba89c684de0b5fe91a013708caaafcf9081
Author: nya <nya@chromium.org>
Date: Tue Feb 14 04:36:44 2017

Do not show available bytes in media views.

BUG= chromium:691110 
TEST=Available bytes is not shown in media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2690853003
Cr-Commit-Position: refs/heads/master@{#450248}

[modify] https://crrev.com/1824eba89c684de0b5fe91a013708caaafcf9081/ui/file_manager/file_manager/foreground/js/gear_menu_controller.js

Comment 4 by nya@chromium.org, Feb 14 2017

Labels: Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 15 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f8642f7dd31ec13856376f74d57dec07e3f536

commit d6f8642f7dd31ec13856376f74d57dec07e3f536
Author: Shuhei Takahashi <nya@chromium.org>
Date: Wed Feb 15 05:36:34 2017

Do not show available bytes in media views.

BUG= chromium:691110 
TEST=Available bytes is not shown in media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2690853003
Cr-Commit-Position: refs/heads/master@{#450248}
(cherry picked from commit 1824eba89c684de0b5fe91a013708caaafcf9081)

Review-Url: https://codereview.chromium.org/2692253005 .
Cr-Commit-Position: refs/branch-heads/2987@{#517}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d6f8642f7dd31ec13856376f74d57dec07e3f536/ui/file_manager/file_manager/foreground/js/gear_menu_controller.js

Comment 7 by sdantul...@chromium.org, Feb 21 2017

Status: Verified (was: Fixed)
Verified on 9202.35.0 / 57.0.2987.72
►

Sign in to add a comment