New issue
Advanced search Search tips

Issue 691087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 689184

Blocking:
issue 725351



Sign in to add a comment

Use the Image Decode Service for pre-decoding images.

Project Member Reported by khushals...@chromium.org, Feb 10 2017

Issue description

Currently image pre-decodes are scheduled using background priority tasks on the TaskGraphRunner. As we move towards using the Image decode service for scheduling image decodes for large images on visible tiles, the pre-decodes should be sent to this service as well. Doing this will first require better prioritization of decodes in the CheckerImageTracker, as visibility of tiles dependent on them changes.
 
vmpstr@, do you have any thoughts on this? We could simply move pre-decoding and locking of checkerable images to use the decode service but that would mean that the upload would happen only when these tiles come within the prepaint region.

Comment 2 by vmp...@chromium.org, May 16 2017

Yeah I think moving the predecode images to use the service is worth pursuing. You're right that we'll need better scheduling. We could do something similar to checker imaging tracker for this.
Cc: ericrk@chromium.org
Since we now have a prioritized queue for images given to the tracker, the scheduling there should work fine. The tracker would just need an additional bit for which images are pre-decodes so it doesn't request an impl-side invalidation for them, but keeps them locked.
Blocking: 725351

Comment 5 by vmp...@chromium.org, May 23 2017

Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature
Status: Fixed (was: Assigned)
Checkerable pre-decodes go to the image worker now, similar to all other image decodes. I think there is one area of optimization here. Since we know that these images may have never been used for raster, we can avoid create a pending tree invalidation for them and just pass the ref for the decode from the checker image tracking to the ImageController which keeps refs for other predecode images.

Sign in to add a comment