New issue
Advanced search Search tips

Issue 691079 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Previous locations:
gerrit:5534


Sign in to add a comment

Make CQ plugin configurable to enable/disable for specific branches

Project Member Reported by npm@chromium.org, Feb 10 2017

Issue description

What steps will reproduce the problem?
1. Go to https://pdfium-review.googlesource.com/c/2652/, notice the branch is chromium/2987 and there are no conflicts but all bots fail with patch failure.
2. Go to https://codereview.chromium.org/2686193003/, it's the same patch on the same branch. Notice that there is a warning message which tells me, hey, I shouldn't run the CQ on this (it will fail anyways).

It's my bad that I forgot I had to just git cl land the merge, but I only remembered after doing the try on Rietveld.

 
Components: -PolyGerrit
Labels: Proj-PolyGerrit-Migration
Per agable's dogfood announcement email, please file CQ integration bugs in the Chromium project.
Project: chromium
Moved issue gerrit:5534 to now be issue chromium:691079.

Comment 3 by npm@chromium.org, Feb 24 2017

Sorry about filing in the wrong project. I'm not even sure about how to land merges in polygerrit properly. When I try to git cl land, I get:

Using 50% similarity for rename/copy detection. Override with --similarity.

It seems this repository has a Commit Queue, which can test and land changes for you. Are you sure you wish to bypass it?
Press Enter to continue, Ctrl+C to abort.
WARNING: some changes from local branch haven't been uploaded
Do you want to submit latest Gerrit patchset and bypass hooks?
Press Enter to continue, Ctrl+C to abort.
WARNING: bypassing hooks and submitting latest uploaded patchset
Traceback (most recent call last):
  File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5333, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 5315, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/npm/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 4363, in CMDland
    options.verbose)
  File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 2559, in CMDLand
    self.SubmitIssue(wait_for_merge=True)
  File "/usr/local/google/home/npm/depot_tools/git_cl.py", line 2466, in SubmitIssue
    wait_for_merge=wait_for_merge)
  File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 558, in SubmitChange
    return ReadHttpJsonResponse(conn, ignore_404=False)
  File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 377, in ReadHttpJsonResponse
    conn, expect_status=expect_status, ignore_404=ignore_404)
  File "/usr/local/google/home/npm/depot_tools/gerrit_util.py", line 370, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Forbidden: submit not permitted

Cc: aga...@chromium.org
Labels: Pri-2 Type-Bug
Status: Untriaged (was: New)
+agable to help triage.

Comment 5 by aga...@chromium.org, May 17 2017

Labels: -Proj-PolyGerrit-Migration Proj-Gerrit-Migration
Ah this had the wrong label so it wasn't in our triage queue. Looking.

Comment 6 by aga...@chromium.org, May 18 2017

Components: Infra>Codereview>Gerrit
Labels: Milestone-Afterglow
Status: Available (was: Untriaged)
Summary: Make CQ plugin configurable to enable/disable for specific branches (was: Add CQ warning for non-master branches in pdfium)
Two things here:

1) submit was not permitted because no one had provided Code-Review+1 on that change.

2) We'll be able to show more messages like this once the CQ plugin is configurable (the chumpdetector plugin already is https://chromium.googlesource.com/infra/gerrit-plugins/chumpdetector/+/master/src/main/java/com/googlesource/chromium/plugins/chumpdetector/GetProjectChumpConfig.java but the cq plugin isn't).

I thought we had a bug on file for that, but I can't find it, so I'm repurposing this one for that.
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: tandrii@chromium.org
Andrii - You own CQ these days and know Gerrit. Any thoughts on how we should triage this bug.
While CQ is triggered by means of CQ+1/+2 votes, the plugin indeed needs separate config file in refs/meta/config, which will duplicate part of cq.cfg, which specifies which refs to watch for [1].

However, I will try to convince others this quarter that CQDaemon should become its own LUCI service with API (but the same cq.cfg). Then, Gerrit CQ plugin would just query CQ service to see if CQ button should be shown. Once completed, this bug is obsolete. But i'm yet to create a design doc for such CQ server, still here is tracking bug: issue 920494

[1] https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/cq/api/config/v2/cq.proto?q=cq.proto&sq=package:chromium&dr&l=107
Components: Infra>Platform>CQ
Status: Available (was: Untriaged)

Sign in to add a comment