Implement allow_network_changed for stale DNS experiment |
||
Issue descriptionThe stale DNS experiment in Cronet has an "allow_network_changed" option to use stale results from other networks. It's currently not fully implemented. There's some work in place, but HostResolverImpl clears HostCache whenever the network changes, so results from previous networks are never available.
,
Feb 13 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92b1af1d8a6162a1a9638d02c3485363ffb60abd commit 92b1af1d8a6162a1a9638d02c3485363ffb60abd Author: mgersh <mgersh@chromium.org> Date: Wed Mar 29 15:49:23 2017 Expire but don't clear HostCache on DNS config change Before this change, HostCache entries are expired (not cleared) on IP address changes, but the entire cache is cleared on DNS config changes. This isn't useful because the distinction is currently only used in an Android-specific experiment, and all network changes on Android involve a DNS config change. Cronet with the stale DNS experiment enabled will now use HostCache entries from other networks if the allow_other_network option is turned on. Chrome itself should not have any changes other than keeping more results in cache that won't be used. BUG= 691078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2785563002 Cr-Commit-Position: refs/heads/master@{#460401} [modify] https://crrev.com/92b1af1d8a6162a1a9638d02c3485363ffb60abd/components/cronet/stale_host_resolver_unittest.cc [modify] https://crrev.com/92b1af1d8a6162a1a9638d02c3485363ffb60abd/net/base/network_change_notifier.cc [modify] https://crrev.com/92b1af1d8a6162a1a9638d02c3485363ffb60abd/net/base/network_change_notifier.h [modify] https://crrev.com/92b1af1d8a6162a1a9638d02c3485363ffb60abd/net/dns/host_resolver_impl.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 13 2017