Create FindTabHelper for iOS |
||
Issue descriptionMove code out of Tab and BVC and into a new FindTabHelper class. Refactor code so that the primary API for the find-in-page feature lives in FindTabHelper, rather than in FindInPageController. Consider hiding FindInPageController and FindInPageModel as internal implementation details. Also consider removing FindInPageController completely and merging its functionality into FindTabHelper. Use the existing desktop class as a guide.
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc commit e6c32ed57fd0f31d1f197e239e17c7b5780f47fc Author: rohitrao <rohitrao@chromium.org> Date: Mon Feb 27 17:16:15 2017 [ios] Simplifies the Find In Page JS unittest. This test does not need a full FindInPageController, so that is removed from the test fixture. Additionally, the find in page unittest files are moved from ios/chrome/browser/web to ios/chrome/browser/find_in_page. BUG=691073 Review-Url: https://codereview.chromium.org/2711513002 Cr-Commit-Position: refs/heads/master@{#453241} [modify] https://crrev.com/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc/ios/chrome/browser/find_in_page/BUILD.gn [rename] https://crrev.com/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc/ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm [rename] https://crrev.com/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc/ios/chrome/browser/find_in_page/js_findinpage_manager_unittest.mm [modify] https://crrev.com/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc/ios/chrome/browser/web/BUILD.gn
,
Mar 3 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/005a643c735aceb7b6075a82026d39227f67dc21 commit 005a643c735aceb7b6075a82026d39227f67dc21 Author: rohitrao <rohitrao@chromium.org> Date: Thu Mar 16 20:52:42 2017 [ios] Moves the Find in Page APIs into FindTabHelper. Hides FindInPageController as an implementation detail of FindTabHelper and moves public APIs to be on FindTabHelper instead. BUG=691073 Review-Url: https://codereview.chromium.org/2724683002 Cr-Commit-Position: refs/heads/master@{#457543} [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/find_in_page/BUILD.gn [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/find_in_page/find_in_page_controller.mm [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/find_in_page/find_tab_helper.h [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/find_in_page/find_tab_helper.mm [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/find_in_page/find_tab_helper_unittest.mm [modify] https://crrev.com/005a643c735aceb7b6075a82026d39227f67dc21/ios/chrome/browser/ui/browser_view_controller.mm
,
Mar 26 2018
Is this completed or more to go? |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 14 2017