New issue
Advanced search Search tips

Issue 691069 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

sizes failing on chromium/Linux x64

Project Member Reported by hirosh...@chromium.org, Feb 10 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c42c445521b0f145afb0603bf7a38d4266e7dd

commit 97c42c445521b0f145afb0603bf7a38d4266e7dd
Author: hiroshige <hiroshige@chromium.org>
Date: Fri Feb 10 20:59:16 2017

Revert of Browser tests for using the new SafeBrowsing protocol (v4) (patchset #8 id:220001 of https://codereview.chromium.org/2675063002/ )

Reason for revert:
Suspected to cause sizes test failing due to static
initializers added to v4_database.cc.

BUG= 691069 

Original issue's description:
> Adding browser tests for PVer4.
>
> Just adding some basic tests for now.
> More coming soon (http://crrev.com/2684663002)
>
> BUG= 682495 
>
> Review-Url: https://codereview.chromium.org/2675063002
> Cr-Commit-Position: refs/heads/master@{#449703}
> Committed: https://chromium.googlesource.com/chromium/src/+/d9bfc537eac0e031058b6df63b4290a645318cf8

TBR=asanka@chromium.org,csharrison@chromium.org,nparker@chromium.org,shess@chromium.org,vakh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 682495 

Review-Url: https://codereview.chromium.org/2687023007
Cr-Commit-Position: refs/heads/master@{#449731}

[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/loader/safe_browsing_resource_throttle.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/services_delegate.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/services_delegate_impl.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/services_delegate_stub.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/services_delegate_stub.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/test_safe_browsing_service.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/chrome/browser/safe_browsing/test_safe_browsing_service.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_database.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_database.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_database_unittest.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_feature_list.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_feature_list.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/97c42c445521b0f145afb0603bf7a38d4266e7dd/components/safe_browsing_db/v4_store.h

Status: Fixed (was: Started)
The bot turned green.

Sign in to add a comment