New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691062 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Component mapping updater failing

Project Member Reported by robert...@chromium.org, Feb 10 2017

Issue description

The component updater is failing:
https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_component_updater/31

The cited reason is:
Component UI>Notifications has more than one team assigned to it: push-notifications-dev@chromium.org, platform-capabilities@chromium.org
Not writing to file due to errors

We need to fix this issue for the auto-updater to resume normal operation.
 
Status: Fixed (was: Untriaged)
Status: Available (was: Fixed)
It seems this is failing again since yesterday: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_component_updater/

The error from the cron job is:
Component Blink>XML has more than one team assigned to it: blink-html-dom@chromium.org, dom-dev@chromium.org

It'd be interesting to find out if the presubmit failed to catch this error or the committer simply bypassed it.
It's possible the committer bypassed it. 

Two files are 

src/third_party/libxml/OWNERS 
Blink>XML, blink-html-dom@chromium.org
I committed this change yesterday and here is the cl link. 
https://codereview.chromium.org/2698093002/
It passed the presubmit. 

src/third_party/WebKit/Source/core/xml/OWNERS
Blink>XML, dom-dev@chromium.org
No record of changing the file from my side. There is no owner listed in this file and a very long list on the higher level. Could we find out who made this change?


This change happened in November: https://chromium.googlesource.com/chromium/src/+/fe01ac6e3bd5a110d0ab43004b68a0ec326ccdec%5E%21/#F4

So it should have warned you on presubmit yesterday, but it didn't. I am investigating.
My bad, I forgot to land my change to the presubmit. Doing that now.
No problem. I'll confirm with owners about team and then make the change. 
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4b87b7f3fc1dcd8a56774b7c597d12792a3694

commit 5e4b87b7f3fc1dcd8a56774b7c597d12792a3694
Author: ymzhang <ymzhang@chromium.org>
Date: Thu Mar 02 19:46:36 2017

[Directory Ownership] correct team mailing list for Blink>XML

Set mailing list of Blink>XML to dom-dev@chromium.org

BUG= 691062 
TBR=dominicc@chromium.org

Review-Url: https://codereview.chromium.org/2726213002
Cr-Commit-Position: refs/heads/master@{#454347}

[modify] https://crrev.com/5e4b87b7f3fc1dcd8a56774b7c597d12792a3694/third_party/libxml/OWNERS

Status: Fixed (was: Available)

Sign in to add a comment