Issue 691061 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	Feb 2017
Cc:	█ roc...@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-Mustash VerifyIn-59 VerifyIn-60 VerifyIn-61

mash: ui service crashes during shutdown in ash service dies

Project Member Reported by jamescook@chromium.org, Feb 10 2017

Issue description

ToT Chrome
Run --mash --ash-debug-shortcuts
Ctrl-Alt-Shift-K to crash ash

Ash goes down, root process tries to quit children, ui service crashes with this stack:

#0 0x7f3a25bb6b7d base::debug::StackTrace::StackTrace()
#1 0x7f3a25bb6f70 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f3a229a9530 <unknown>
#3 0x7f3a25c257b7 base::ThreadTaskRunnerHandle::Get()
#4 0x7f3a29d81f43 ui::ws::DefaultWindowTreeBinding::CreateClientForShutdown()
#5 0x7f3a29d80f52 ui::ws::WindowTreeBinding::ResetClientForShutdown()
#6 0x7f3a29d77cfa ui::ws::WindowTree::PrepareForWindowServerShutdown()
#7 0x7f3a29d76daa ui::ws::WindowServer::~WindowServer()
#8 0x7f3a29d77251 ui::ws::WindowServer::~WindowServer()
#9 0x7f3a2577c015 ui::Service::~Service()
#10 0x7f3a2577c381 ui::Service::~Service()
#11 0x7f3a268e1ba3 service_manager::ServiceContext::~ServiceContext()
#12 0x7f3a268e1c51 service_manager::ServiceContext::~ServiceContext()
#13 0x7f3a2576ecd3 mash::MashPackagedService::~MashPackagedService()
#14 0x7f3a2576ed21 mash::MashPackagedService::~MashPackagedService()
#15 0x7f3a268e1ba3 service_manager::ServiceContext::~ServiceContext()
#16 0x7f3a268e1c51 service_manager::ServiceContext::~ServiceContext()
#17 0x7f3a23b50cf5 MashMain()
#18 0x7f3a23b4d5d5 ChromeMain
#19 0x7f3a21603796 __libc_start_main
#20 0x7f3a23b4d389 _start

This is similar to  issue 689197 . It looks like the MessageLoop is being destroyed before service_manager::ServiceContext.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94

commit 24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94
Author: jamescook <jamescook@chromium.org>
Date: Fri Feb 10 21:34:03 2017

mash: Fix shutdown crashes by tearing down ServiceContext before message loop

The ui service crashes during shutdown when there isn't a valid message loop.
Tear down the service_manager::ServiceContext before the MessageLoop. Also
change some unique_ptr<> member variables to stack variables to enforce the
correct ordering.

BUG= 691061 
TEST=chrome --mash, kill ash, ui service shuts down cleanly

Review-Url: https://codereview.chromium.org/2686353002
Cr-Commit-Position: refs/heads/master@{#449741}

[modify] https://crrev.com/24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94/chrome/app/mash/mash_runner.h