New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Suspect data in Omnibox.SuggestionUsed.NearbyURLCount histogram

Project Member Reported by mattreynolds@chromium.org, Feb 10 2017

Issue description

Chrome Version: Chrome M57
OS: Android, iOS

The NearbyURLCount histogram shows unusually high counts for values greater than 50.
 
Components: UI>Browser>Omnibox
This seems to indicate a strange behavior in Android: users selecting a suggestion without a Start(on_focus) event being called.

https://codereview.chromium.org/2689803002/
Adds additional logging to look for this case explicitly.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b89f92fabae32da4caae8f1b0c387888ade9496

commit 6b89f92fabae32da4caae8f1b0c387888ade9496
Author: mattreynolds <mattreynolds@chromium.org>
Date: Thu Feb 23 20:53:29 2017

Improve nearby URL count metrics for Physical Web omnibox provider

The nearby_url_count_ field was not initialized correctly in the query
suggest case. This CL ensures that the field is always set to the
number of metadata items returned by the Physical Web data source.

A new histogram is added to record the number of nearby URLs when the
omnibox is focused. Another histogram is added to detect how frequently
this corner case occurs.

BUG= 691059 

Review-Url: https://codereview.chromium.org/2689803002
Cr-Commit-Position: refs/heads/master@{#452620}

[modify] https://crrev.com/6b89f92fabae32da4caae8f1b0c387888ade9496/components/omnibox/browser/physical_web_provider.cc
[modify] https://crrev.com/6b89f92fabae32da4caae8f1b0c387888ade9496/components/omnibox/browser/physical_web_provider.h
[modify] https://crrev.com/6b89f92fabae32da4caae8f1b0c387888ade9496/components/omnibox/browser/physical_web_provider_unittest.cc
[modify] https://crrev.com/6b89f92fabae32da4caae8f1b0c387888ade9496/tools/metrics/histograms/histograms.xml

FYI, the counts for all these histograms now look sane in the Android dev channel.  [link omitted on public bug]

Close as fixed?
Status: Fixed (was: Started)
Yep, the results in NearbyURLCount.AtFocus and NearbyURLCount.AtMatchCreation seem reasonable.  Marking this as fixed.

I notice that Omnibox.PhysicalWebProvider.SuggestionUsedWithoutOmniboxFocus records that the omnibox was used without focus ~1% of the time on Android. Since we still don't know what is causing that, I've filed a new bug so we can continue to track it:

https://bugs.chromium.org/p/chromium/issues/detail?id=699706

Sign in to add a comment