New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691054 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix/remove audio_unittests for android

Project Member Reported by w...@chromium.org, Feb 10 2017

Issue description

It's broken and maybe never worked: 

I   13.504s list_tests(05efda3200ea45d8)  No tests found. Output:
I   13.505s list_tests(05efda3200ea45d8)    [FATAL:jni_android.cc(130)] Failed to find class org/chromium/ui/gl/SurfaceTextureListener
I   13.505s TimeoutThread-1-for-list_tests(060d42460ace2a65)  [host]> /prj/qct/webtech/archive06/users/nightly/master-baseline/061c556a-e802-11e6-b3b5-78e3b5152870/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 060d42460ace2a65 pull /data/local/tmp/temp_file-49e9189503cd0 /tmp/tmpDmJxdo/tmp_ReadFileWithPull
I   13.506s list_tests(05efda3200ea45d8)    #00 0xa182602b /data/app/org.chromium.native_test-1/lib/arm/lib_audio_unittests__library.so+0x000a502b
I   13.510s TimeoutThread-1-for-delete_temporary_file(05efda3200ea45d8)  [host]> /prj/qct/webtech/archive06/users/nightly/master-baseline/061c556a-e802-11e6-b3b5-78e3b5152870/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 05efda3200ea45d8 shell 'rm -f /sdcard/temp_file-df06258d811e5.gtest_out'
I   13.513s list_tests(05efda3200ea45d8)    #01 0xa1818685 /data/app/org.chromium.native_test- ...

 
Took a quick look at this because I've been looking at some JNI related stuff, but it looks like there's missing dependencies on //ui/android:ui_java and //media/base/android:media_java.

Adding these to //media:audio_unittests will allow the tests to run and pass. 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7ac891577ddd5fddc4846eba0496f6d8dddab6c

commit f7ac891577ddd5fddc4846eba0496f6d8dddab6c
Author: watk <watk@chromium.org>
Date: Tue Feb 14 23:54:46 2017

media: Fix build config for audio_unittests on Android

We were missing some deps which meant this test didn't run on Android.
We didn't notice because we usually run these tests through
media_unittests.

BUG= 691054 

Review-Url: https://codereview.chromium.org/2694323002
Cr-Commit-Position: refs/heads/master@{#450517}

[modify] https://crrev.com/f7ac891577ddd5fddc4846eba0496f6d8dddab6c/media/BUILD.gn
[modify] https://crrev.com/f7ac891577ddd5fddc4846eba0496f6d8dddab6c/media/base/android/BUILD.gn

Comment 3 by w...@chromium.org, Feb 14 2017

Status: Fixed (was: Available)

Sign in to add a comment