external .repo/manifest.xml not getting updated properly with weave remotes |
|||||||
Issue descriptionthis CL is failing on the external bots: https://chromium-review.googlesource.com/433081 it can't find the weave source repo. all the internal bots are passing. the manifest/full.xml and manifest-internal/external_full.xml are in sync. looking at the build log: https://build.chromium.org/p/chromiumos/builders/amd64-generic-paladin/builds/28438/ specifically the sync stage: https://build.chromium.org/p/chromiumos/builders/amd64-generic-paladin/builds/28438/steps/CommitQueueSync/logs/stdio when it prints the manifest, doesn't list the weave repo! if i do the same `repo init` command to get an external checkout, the weave repo shows up just fine there. when i ssh into the bot, indeed .repo/manifest.xml is missing anything weave related. both the remote and the <project> for it. when i look at .repo/manifest/full.xml though, everything is in there. looks like our .repo/manifest.xml generation logic is incorrectly dropping the weave remotes.
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e137bb923b80571e694951d4c1ae774312c2972b commit e137bb923b80571e694951d4c1ae774312c2972b Author: Mike Frysinger <vapier@chromium.org> Date: Sat Feb 11 08:35:22 2017 cbuildbot: whitelist weave remotes for external manifests BUG= chromium:691044 TEST=precq passes Change-Id: If5e89eb4ac7e193a72f7e1e91d1183587d964435 Reviewed-on: https://chromium-review.googlesource.com/441124 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Simran Basi <sbasi@chromium.org> [modify] https://crrev.com/e137bb923b80571e694951d4c1ae774312c2972b/cbuildbot/config_dump.json [modify] https://crrev.com/e137bb923b80571e694951d4c1ae774312c2972b/cbuildbot/chromeos_config.py
,
Feb 11 2017
the libweave CL landed fine now
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Jun 21 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vapier@chromium.org
, Feb 10 2017