New issue
Advanced search Search tips

Issue 691041 link

Starred by 1 user
Status: WontFix
Owner:
khushals...@chromium.org
Closed: Feb 2017
Cc:
vmp...@chromium.org
enne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 686267



Sign in to add a comment

Update SyncedProperty to handle impl-side invalidation pending tree.

Project Member Reported by khushals...@chromium.org, Feb 10 2017 
With impl-side invalidations, we might end up creating and activating a pending tree on the impl thread *after* a BeginMainFrame was sent to the main thread. In this case we don't want the internal tracking in SyncedProperty to assume that the sent deltas were resolved during activation.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc91d0e5b2f135eee29fc0e2a506747a18dc439

commit 6dc91d0e5b2f135eee29fc0e2a506747a18dc439
Author: khushalsagar <khushalsagar@chromium.org>
Date: Tue Feb 28 05:10:07 2017

cc: Glue LTHI and Scheduler changes for checker-imaging.

This change glues together the scheduling and tile management changes
for checker-imaging via ProxyImpl and SingleThreadProxy for enabling
checker-imaging. And adds integration LayerTreeTests, including a
scroll test to ensure that an impl-side pending tree does not affect
SyncedProperty state synchronization.

BUG= 686267 ,  691041 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2717553005
Cr-Commit-Position: refs/heads/master@{#453508}

[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/BUILD.gn
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/playback/raster_source.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/scheduler/scheduler_state_machine.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/test/layer_tree_test.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/test/layer_tree_test.h
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/test/test_hooks.h
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host.h
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host_impl.h
[add] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host_unittest_checkerimaging.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/proxy_impl.cc
[modify] https://crrev.com/6dc91d0e5b2f135eee29fc0e2a506747a18dc439/cc/trees/single_thread_proxy.cc

Comment 2 by khushals...@chromium.org, Feb 28 2017

Status: WontFix (was: Assigned)
No changes necessary to SyncedProperty. The change above added a test to validate this as well.
►

Sign in to add a comment