Clearing cached data also deletes persistent offline pages |
|||||||
Issue descriptionWhen the user activates Chrome Settings->Privacy->Clear Browsing Data->Cached Images and Files->Clear Data This is causing the deletion of all offlined pages, both temporary (the ones that have expiration dates) and persistent ones. The former is OK and expected but the latter is not as it includes user requested page downloads which are not "cached files".
,
Feb 16 2017
I think there's some misunderstanding in this bug... The bug is that the automatic clear of the pages (in storage manager) would clear the persistent pages as well. The mentioned way of clearing data would not affect user-requested downloads. The fix will focus on the first part, which is in storage manager auto clearing.
,
Feb 17 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0386b22583a0df497019c2d7d23721f701911b55 commit 0386b22583a0df497019c2d7d23721f701911b55 Author: romax <romax@chromium.org> Date: Fri Feb 17 23:56:44 2017 [Offline Pages] Fix storage manager deleting persistent pages. Fixed an issue where persistent pages would be deleted by storage manager when clearing expired pages. BUG= 691023 Review-Url: https://codereview.chromium.org/2700563005 Cr-Commit-Position: refs/heads/master@{#451405} [modify] https://crrev.com/0386b22583a0df497019c2d7d23721f701911b55/components/offline_pages/core/offline_page_storage_manager.cc [modify] https://crrev.com/0386b22583a0df497019c2d7d23721f701911b55/components/offline_pages/core/offline_page_storage_manager_unittest.cc
,
Feb 18 2017
fixed per the second comment.
,
Feb 22 2017
,
Feb 22 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1d74d4f8aa6bb7c85858eeed42119aa049643ba commit e1d74d4f8aa6bb7c85858eeed42119aa049643ba Author: Dmitry Titov <dimich@chromium.org> Date: Wed Feb 22 21:23:56 2017 [Offline Pages] Fix storage manager deleting persistent pages. Fixed an issue where persistent pages would be deleted by storage manager when clearing expired pages. BUG= 691023 Review-Url: https://codereview.chromium.org/2700563005 Cr-Commit-Position: refs/heads/master@{#451405} (cherry picked from commit 0386b22583a0df497019c2d7d23721f701911b55) Review-Url: https://codereview.chromium.org/2707363002 . Cr-Commit-Position: refs/branch-heads/2987@{#645} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/e1d74d4f8aa6bb7c85858eeed42119aa049643ba/components/offline_pages/core/offline_page_storage_manager.cc [modify] https://crrev.com/e1d74d4f8aa6bb7c85858eeed42119aa049643ba/components/offline_pages/core/offline_page_storage_manager_unittest.cc
,
Feb 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by romax@chromium.org
, Feb 10 2017Status: Assigned (was: Untriaged)