New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691022 link

Starred by 4 users
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ eostroukhov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Unable to attach to Node.JS from chrome://inspect page

Project Member Reported by eostroukhov@chromium.org, Feb 10 2017 
1. Start Node.js process, e.g. node --inspect myscript.js
2. Open Chrome and navigate to chrome://inspect
3. Click on "inspect" link next to Node.js process.

Expected:
DevTools window opens, attached to a Node.js instance.

Actual:
Browser window opens showing an error.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41332227e15f05ae9dcbfe1ef6297d041cfc1b9a

commit 41332227e15f05ae9dcbfe1ef6297d041cfc1b9a
Author: eostroukhov <eostroukhov@chromium.org>
Date: Fri Feb 10 19:45:35 2017

[DevTools] Allow bundled DevTools for Node targets

BUG= 691022 

Review-Url: https://codereview.chromium.org/2693493003
Cr-Commit-Position: refs/heads/master@{#449699}

[modify] https://crrev.com/41332227e15f05ae9dcbfe1ef6297d041cfc1b9a/chrome/browser/ui/webui/devtools_ui.cc

Comment 2 by eostroukhov@chromium.org, Feb 10 2017

Labels: Merge-Request-57

Comment 3 by eostroukhov@chromium.org, Feb 10 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 11 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Feb 13 2017 

Please merge your change to M57 branch 2987 by 5:00 PM PT Monday (02/13) so we can pick it up for next beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 13 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4449f5ac231319e6a27b2a7aa6aa7190c944d4bf

commit 4449f5ac231319e6a27b2a7aa6aa7190c944d4bf
Author: eostroukhov <eostroukhov@chromium.org>
Date: Mon Feb 13 19:14:47 2017

[DevTools] Allow bundled DevTools for Node targets

BUG= 691022 

Review-Url: https://codereview.chromium.org/2693493003
Cr-Commit-Position: refs/heads/master@{#449699}
(cherry picked from commit 41332227e15f05ae9dcbfe1ef6297d041cfc1b9a)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2691083002
Cr-Commit-Position: refs/branch-heads/2987@{#481}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4449f5ac231319e6a27b2a7aa6aa7190c944d4bf/chrome/browser/ui/webui/devtools_ui.cc

Comment 7 by eostroukhov@chromium.org, Apr 14 2017

Cc: eostroukhov@chromium.org
 Issue 674394  has been merged into this issue.
►

Sign in to add a comment